Fix passwordless key-based auth prompting for mandatory password#21
Merged
macnev2013 merged 1 commit intomainfrom Mar 18, 2026
Merged
Fix passwordless key-based auth prompting for mandatory password#21macnev2013 merged 1 commit intomainfrom
macnev2013 merged 1 commit intomainfrom
Conversation
When connecting to servers using private key authentication (e.g. OCI instances), the app incorrectly showed a password prompt if no password was saved in Keychain. Key-based auth doesn't require a password, so the prompt blocked the connection entirely. The fix checks `connection.authMethod` before showing the password prompt. For `.privateKey` auth, it connects directly with an empty password string (which downstream code already handles correctly by passing nil as the passphrase). Both SFTP browser and terminal connection paths are fixed. Fixes: #16 Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connectToServer()andrequestTerminal()now checkconnection.authMethodbefore showing the password prompt.privateKeyauth with no saved passphrase, connects directly with empty string (downstream code already converts this tonil)Changes
ConnectionListViewModel.swiftauthMethod == .privateKeycheck in bothconnectToServer()andrequestTerminal()to skip password promptTest plan
Fixes #16
🤖 Generated with Claude Code