feat: drag/drop entities + move/copy + fix canvas mention nodes#1002
Merged
feat: drag/drop entities + move/copy + fix canvas mention nodes#1002
Conversation
gbirman
commented
Jan 14, 2026
| } | ||
| }); | ||
|
|
||
| // Get icon type using the same logic as EntityWithEverything |
Contributor
Author
There was a problem hiding this comment.
there's a bunch of logic bewteen entitywitheverything and previewitem we can probably share, maybe im missing stuff
This reverts commit 9fdb6a0.
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
sedson
approved these changes
Jan 15, 2026
Contributor
sedson
left a comment
sedson
left a comment
There was a problem hiding this comment.
did not look super close at project drop. general cleanups, md and canvas LGTM
| id: draggable.data.id, | ||
| itemName: draggable.data.name, | ||
| }); | ||
| const handleKeyDown = (e: KeyboardEvent) => { |
Contributor
There was a problem hiding this comment.
nit: our hotkey system has a global pressedKeys signal
packages/core/hotkey/state.ts
Contributor
Author
There was a problem hiding this comment.
true, i like scoping it to the dnd provider though but can do as a follow up
| const [visible, setVisible] = createSignal(false); | ||
|
|
||
| // Flush pending saves on cleanup to prevent data loss when navigating away | ||
| onCleanup(() => { |
gbirman
deleted the
gab/m-5363-drag-soup-entry-into-folder-as-a-move-operation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO as followup: i'd like to get the access status ahead of time so we don't try to move/display a droppable if you don't have edit access on shared project. atm that code returns a 401 so a) we're doing unnecessary jwt refreshes b) we only show a generic failure toast without indicating that you are unauthorized to do that operation because you don't have edit access which would make it easier for the user to understand
Screenshots, GIFs, and Videos
CleanShot.2026-01-14.at.16.09.30.mp4