feat(email): allow editing and sending email drafts when there is no thread#1005
Merged
feat(email): allow editing and sending email drafts when there is no thread#1005
Conversation
…tch depending on key
Contributor
Code ReviewFound 2 bugs that need to be fixed: Issue 1: Missing assignment in createEmailFormState.tsLocation: The return value of Current: } else if (purpose?.type === 'replying_to') {
options?.getDraftForMessageReply(purpose?.messageID);
}Should be: } else if (purpose?.type === 'replying_to') {
draft = options?.getDraftForMessageReply(purpose?.messageID);
}Impact: When replying to a message, any existing draft data (body, subject, recipients, attachments) will not be loaded. Issue 2: Incorrect null check in EmailInput.tsxLocation: Using Current: isEditingExisting={props.replyingTo() == null && props.draft !== null}Should be: isEditingExisting={props.replyingTo() == null && props.draft != null}Impact: The condition will incorrectly evaluate to |
…ing-email-draft-with-no-thread
Contributor
peterchinman
approved these changes
Jan 15, 2026
…ing-email-draft-with-no-thread
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR adds the ability to edit and send a draft created during the email compose step. Going to "Email" and filtering by drafts, you can open the draft in the email thread view and edit the draft and send from there.
TODO in a separate PR:
Screenshots, GIFs, and Videos