Skip to content

unified-list: fix multiple entity rows showing same hover state#1012

Merged
aquaductape merged 1 commit intomainfrom
Caleb/fix-entity-hover-logic
Jan 15, 2026
Merged

unified-list: fix multiple entity rows showing same hover state#1012
aquaductape merged 1 commit intomainfrom
Caleb/fix-entity-hover-logic

Conversation

@aquaductape
Copy link
Copy Markdown
Contributor

Multiple entity rows are showing same hover state, showing mark as down checkbox, due to hover condition is compared by entity.id.

Fix is changing hover comparison to entity component id.

…condition is checked by entity id. Now hover condition is checked by entity row's component id
@aquaductape aquaductape requested a review from a team as a code owner January 15, 2026 15:14
@github-actions
Copy link
Copy Markdown

@claude
Copy link
Copy Markdown
Contributor

claude bot commented Jan 15, 2026

Code review

This PR fixes a bug where multiple entity rows show the same hover state. The implementation correctly addresses the issue by using Symbol() to create unique identifiers for each component instance.

However, there is one compliance issue:

Missing Test for Bug Fix

Issue: The CLAUDE.md testing guidelines require that bug fixes include tests to identify the issue before fixing it:

"Testing - Write tests for your changes. When fixing bugs or regressions, identify the issue with a test before fixing it."

Recommendation: Add tests that verify:

  1. Multiple entity rows with the same entity.id maintain independent hover states
  2. Hovering over one entity row does not trigger the hover state on other rows with the same entity ID

This will help prevent regression of this bug in the future.


Technical review: The code changes themselves are correct - using Symbol() per component instance ensures each rendered entity has a unique identifier, preventing the hover state collision that occurred when using the shared entity.id.

@aquaductape aquaductape merged commit d4314f0 into main Jan 15, 2026
23 checks passed
@aquaductape aquaductape deleted the Caleb/fix-entity-hover-logic branch January 15, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants