fix(email): thread scroll jumping and loading indicator#1014
Merged
Conversation
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
peterchinman
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where refetching of data would cause the messages list to rerender and cause scroll jumping and loss of input focus on drafts. Also, this updates the
isFetchingstate to only occur during the initial load and when subsequent pages are fetched instead of anytime data is being fetched. This stops the loading indicator from showing after draft edits.Screenshots, GIFs, and Videos
Loading indicator at top: