Skip to content

Swap keyboard shortcut behavior in Launcher menu#1024

Merged
jbecke merged 2 commits intomainfrom
claude/swap-launcher-shortcuts-0TUT7
Jan 15, 2026
Merged

Swap keyboard shortcut behavior in Launcher menu#1024
jbecke merged 2 commits intomainfrom
claude/swap-launcher-shortcuts-0TUT7

Conversation

@jbecke
Copy link
Copy Markdown
Contributor

@jbecke jbecke commented Jan 15, 2026

Change default launcher shortcut behavior to open items in a new split. Holding option now opens in the current split instead.

Change default launcher shortcut behavior to open items in a new split.
Holding option now opens in the current split instead.
@jbecke jbecke requested a review from a team as a code owner January 15, 2026 19:04
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 15, 2026

@claude
Copy link
Copy Markdown
Contributor

claude bot commented Jan 15, 2026

Code review

Missing tests for behavioral changes

This PR changes the keyboard shortcut behavior in the Launcher component by inverting the shouldInsert logic, which affects when items open in a new split vs. current split. According to CLAUDE.md Rule 4, tests should be written for changes like this.

Issue: No tests were added for this behavioral change affecting 7 different launcher actions:

Why this matters: The codebase already has patterns for testing similar keyboard modifier behavior (see openInNewSplitForMention.test.ts). This behavioral change affects user workflows and could regress without test coverage.

Suggested fix: Add unit tests that verify the shouldInsert parameter is correctly set based on the pressedKeys().has('opt') state for these launcher actions.

- Note -> Docs with hotkey 'd'
- Canvas now uses hotkey 'n'
@jbecke jbecke merged commit 959f983 into main Jan 15, 2026
21 checks passed
@jbecke jbecke deleted the claude/swap-launcher-shortcuts-0TUT7 branch January 15, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants