fix(dss|properties): inconsistent deleted at

[whutchinson98]

This PR addresses the inconsistency issues around handling deleted item access in properties service. It also adds the deletedAt field to DocumentMetadata

[claude]

Code review

I found 1 issue that needs attention:

Missing err attribute in tracing::instrument

File: rust/cloud-storage/macro_db_client/src/item_access/get.rs:6

According to CLAUDE.md line 300:

Include err when adding the tracing::instrument attribute to functions. Never include level = "info".

The #[tracing::instrument(skip(db))] attribute should include err since this function returns a Result type.

Suggested fix:

#[tracing::instrument(skip(db), err)]

---

Review summary: Checked for bugs and CLAUDE.md compliance. Found 1 CLAUDE.md violation. No bugs detected.

[claude]

I found one CLAUDE.md compliance issue in this PR.

In rust/cloud-storage/macro_db_client/src/item_access/get.rs at line 6, the tracing::instrument attribute is missing the err parameter. Functions that return Result types should include err in their tracing instrumentation per CLAUDE.md guidelines.

The function should use:
#[tracing::instrument(skip(db), err)]

Reference:

macro/rust/cloud-storage/CLAUDE.md

Line 300 in cc3c254

- Include `err` when adding the `tracing::instrument` attribute to functions. Never include `level = "info"`.

[github-actions]

Preview: https://hutch-fix-inconsistent-deleted-0dz8mk.preview.macro.com/app (b3b9a2e)