style(item preview): change styling on chat attachment items#1203
Merged
style(item preview): change styling on chat attachment items#1203
Conversation
Contributor
aidanhb
commented
Jan 27, 2026
aidanhb
commented
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
sedson
approved these changes
Jan 27, 2026
| ref={buttonRef} | ||
| class="text-ink-base text-sm ring-1 ring-edge-muted rounded-xs hover:bg-panel-hover flex flex-row h-6 px-2 justify-center items-center cursor-pointer" | ||
| onMouseEnter={() => { | ||
| if (!isTouchDevice()) { |
Contributor
There was a problem hiding this comment.
could be wrong, but mouseEnter and leave should not even fire on touch devices
Contributor
Author
There was a problem hiding this comment.
I think some touch devices will fire a mouse enter event on tap. It also could be fine to have the preview flash on screen briefly, but since it's interactive I don't want to entice the user
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.