feat(icons) - add animating versions of icons in Launcher and Soup filters#1229
Merged
feat(icons) - add animating versions of icons in Launcher and Soup filters#1229
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Add animated icons for Email, Canvas, Folder, and Code buttons. Remove unused static SVG imports. Fix incorrect titles in diagram and folder icon components. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
aidanhb
changed the title
sedson
approved these changes
Feb 10, 2026
| onMouseEnter={() => setIsHovered(true)} | ||
| onMouseLeave={() => setIsHovered(false)} | ||
| > | ||
| {ENABLE_ANIMATED_ICONS && props.animatedIcon ? ( |
Contributor
There was a problem hiding this comment.
use SolidJs Show not conditional chaining
Contributor
Code reviewFound 1 issue: CSS class mismatch in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds animating icons, toggle-able behind flag
ENABLE_ANIMATED_ICONS.Animates all icons in Launcher, and for all entity type filters in unified list (soup).
Next step: animate icons for signal/noise as well as preview.