style(email): Message dark/light mode handling#1259
Merged
evanhutnik merged 1 commit intomainfrom Jan 30, 2026
Merged
Conversation
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix email dark mode styles conflicting with app theme
Problem:
Email HTML content often includes
@media (prefers-color-scheme: dark)CSS rules that automatically apply dark mode styles when the user's system is in dark mode. We should ignore these because we do own themes independent of the user's OS light/dark mode. We also do our own text colour handling for dark/light.Solution:
Strip
prefers-color-schememedia queries from email CSS during HTML parsing. This ensures email content displays consistently regardless of the user's system theme.The tests don't actually display what the FE displays as they don't include the logic above the
transform-email-colors.ts. Will update the test framework later to better represent what we see on the FE.Before:
After:
Before:
After: