Merged
Conversation
seanaye
reviewed
Jan 30, 2026
| #[cfg(target_os = "ios")] | ||
| #[unsafe(no_mangle)] | ||
| extern "C" fn on_app_resumed() { | ||
| let Some(handle) = GLOBAL_APP_HANDLE.get() else { |
Contributor
There was a problem hiding this comment.
storing the app handle in a oncelock is kinda weird. We should probably follow the recommended paradigm for calling from swift -> rust, because I think most plugins do not do this.
If this works though I guess you could merge it and I could look at this as a follow up
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tauri-plugin-app-events was crashing the app. Replaced the plugin with a native iOS lifecycle observer, which triggers a Rust FFI to trigger the javascript heartbeat check.
Note that there is a Tauri PR to solve the issue that this heartbeat method resolves. When that is merged we should use that handler for web content process termination instead of the heartbeat method.