Merged
Conversation
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
seanaye
requested changes
Feb 6, 2026
Comment on lines
+71
to
+73
| trace_bytes[8..16] | ||
| .try_into() | ||
| .expect("slice is always 8 bytes"), |
Contributor
There was a problem hiding this comment.
As much as I would like to believe this is true, dd will probably change this and then our app will start to crash
Contributor
There was a problem hiding this comment.
We should probably return early if this fails
Member
Author
There was a problem hiding this comment.
This can't fail. trace id to bytes always returns this. so this will always be valid
/// Return the representation of this trace id as a byte array.
pub const fn to_bytes(self) -> [u8; 16] {
self.0.to_be_bytes()
}
seanaye
approved these changes
Feb 6, 2026
dev-rb
pushed a commit
that referenced
this pull request
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Datadog does not automatically link our OTEL logging with our normal tracing logs. This should enable this.