chore(dcs): Kill dcs websocket server#1599
Conversation
|
|
||
| [features] | ||
| local_auth = [] | ||
| local_auth = ["macro_middleware/local_auth"] |
There was a problem hiding this comment.
we should remove this feature. if you want to use local auth you can just reference macro_middleware/local_auth directly
There was a problem hiding this comment.
how should I be running locally now? is there a feature flag that replaces this?
| @@ -1 +1 @@ | |||
| export JWT_SECRET_KEY := env('JWT_SECRET_KEY', 'dummyval') | |||
There was a problem hiding this comment.
We really shouldn't be putting all these in a justfile. I know they've been here for a while but this is yet another thing to keep up to date. just rely on the SOPS file for all your env needs.
| status: ExtractionStatusEnum, | ||
| }, | ||
|
|
||
| /// pdf completion |
There was a problem hiding this comment.
if this is explicitly for pdf completions perhaps it should be called PdfCompletionResponse
|
|
||
| /// Spawns a tokio task to send a remove chat message to the search text extractor | ||
| /// Spawns a tokio task to send a remove chat message from the search text extractor | ||
| // used in edit_message which is dead for now |
There was a problem hiding this comment.
So we are no longer able to edit messages?
There was a problem hiding this comment.
temporary sunset. is currently broken in prod
| #[tracing::instrument(err, skip(ctx, chat, incoming_message), fields(chat_id=?incoming_message.chat_id))] | ||
| pub async fn store_incoming_message( | ||
| ctx: Arc<ApiContext>, | ||
| user_id: &str, |
There was a problem hiding this comment.
we should be using MacroUserId types for user_id
| #[tracing::instrument(err, skip(ctx, messages), fields(chat_id=?chat_id, message_count=messages.len()))] | ||
| pub async fn store_conversation_messages( | ||
| ctx: Arc<ApiContext>, | ||
| user_id: &str, |
| updated_at: created_at, | ||
| }; | ||
|
|
||
| let message_id = create_chat_message(ctx.db.clone(), chat_id, new_chat_message) |
There was a problem hiding this comment.
create_chat_message should probably be refactored to take a reference to PgPool instead of requiring us to clone it a bunch
|
The util folder in |
|
models are also an un-refactored rename of the previous ws models. |
ehayes2000
changed the title
rebasington
2 participants
No description provided.