Conversation
seanaye
left a comment
There was a problem hiding this comment.
Do we want this? This removes a lot of the actual internal information that might be useful when diagnosing problems. There is already a display implementation for this struct, can we just use Display instead of getting rid of the Debug?
The output might be a bit verbose but I don't think its unreadable
It's effectively unusable for any sort of monitoring or logging. I don't think there will ever be a point where we care about the internals tbh. This is just a wrapper to safely ensure we are passing valid user ids into macro and as long as we see those ids cleanly in the logs this will be ideal |
fixes the extremely unreadable/unusable logs that were occurring before