Skip to content

fix: macro user id logging#1663

Merged
whutchinson98 merged 1 commit intomainfrom
hutch/improve-macro-user-id-log
Feb 25, 2026
Merged

fix: macro user id logging#1663
whutchinson98 merged 1 commit intomainfrom
hutch/improve-macro-user-id-log

Conversation

@whutchinson98
Copy link
Copy Markdown
Member

@whutchinson98 whutchinson98 commented Feb 25, 2026

fixes the extremely unreadable/unusable logs that were occurring before

image

Copy link
Copy Markdown
Contributor

@seanaye seanaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this? This removes a lot of the actual internal information that might be useful when diagnosing problems. There is already a display implementation for this struct, can we just use Display instead of getting rid of the Debug?

The output might be a bit verbose but I don't think its unreadable

@whutchinson98
Copy link
Copy Markdown
Member Author

Do we want this? This removes a lot of the actual internal information that might be useful when diagnosing problems. There is already a display implementation for this struct, can we just use Display instead of getting rid of the Debug?

The output might be a bit verbose but I don't think its unreadable

It's effectively unusable for any sort of monitoring or logging. I don't think there will ever be a point where we care about the internals tbh. This is just a wrapper to safely ensure we are passing valid user ids into macro and as long as we see those ids cleanly in the logs this will be ideal

@whutchinson98 whutchinson98 merged commit 5de89a7 into main Feb 25, 2026
40 checks passed
@whutchinson98 whutchinson98 deleted the hutch/improve-macro-user-id-log branch February 25, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants