Skip to content

feat(notif): email templating#1687

Merged
seanaye merged 4 commits intomainfrom
seanaye/feat/email-templating
Feb 27, 2026
Merged

feat(notif): email templating#1687
seanaye merged 4 commits intomainfrom
seanaye/feat/email-templating

Conversation

@seanaye
Copy link
Copy Markdown
Contributor

@seanaye seanaye commented Feb 26, 2026

This PR adds the capability to format emails for the digest, given an input DigestBatch we can format all of the notifications into an email for the user.

We then integrate this formatting with the notification sandbox

  • add email formating crate
  • implement the email templating
  • update the template
  • wrap over email_formatter email in sandbox

@seanaye seanaye force-pushed the seanaye/feat/email-templating branch from fcc1ebf to b366052 Compare February 26, 2026 15:23
@seanaye seanaye changed the base branch from main to seanaye/feat/notif-sandbox February 26, 2026 15:26
@seanaye seanaye marked this pull request as ready for review February 26, 2026 15:26
@seanaye seanaye requested a review from a team as a code owner February 26, 2026 15:26
@seanaye seanaye force-pushed the seanaye/feat/email-templating branch from b366052 to cb3f031 Compare February 26, 2026 15:50
@seanaye seanaye force-pushed the seanaye/feat/notif-sandbox branch 2 times, most recently from b55bba0 to 50d32c7 Compare February 26, 2026 16:07
@seanaye seanaye force-pushed the seanaye/feat/email-templating branch from cb3f031 to 5100a0c Compare February 26, 2026 16:07
Copy link
Copy Markdown
Member

@whutchinson98 whutchinson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This crate seems pretty specific to notification emails. Should probably be named notification_email_formatting instead imo

@seanaye seanaye force-pushed the seanaye/feat/email-templating branch from 5100a0c to dee996d Compare February 26, 2026 19:13
@seanaye seanaye force-pushed the seanaye/feat/notif-sandbox branch 2 times, most recently from 7663fe4 to e5b3023 Compare February 26, 2026 21:03
@seanaye seanaye force-pushed the seanaye/feat/email-templating branch 2 times, most recently from 610913e to b72fa5b Compare February 26, 2026 21:20
@seanaye seanaye force-pushed the seanaye/feat/notif-sandbox branch from e5b3023 to 837cb81 Compare February 26, 2026 21:20
Base automatically changed from seanaye/feat/notif-sandbox to main February 26, 2026 21:33
@seanaye seanaye force-pushed the seanaye/feat/email-templating branch from b72fa5b to 0a5c830 Compare February 26, 2026 21:33
@seanaye
Copy link
Copy Markdown
Contributor Author

seanaye commented Feb 27, 2026

This crate seems pretty specific to notification emails. Should probably be named notification_email_formatting instead imo

Ill change in a follow up to avoid confilcts

@seanaye seanaye merged commit c20acbb into main Feb 27, 2026
40 checks passed
@seanaye seanaye deleted the seanaye/feat/email-templating branch February 27, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants