feat: hardcode legacy_user_permissions has_trialed to be true#1709
Merged
whutchinson98 merged 1 commit intomainfrom Feb 27, 2026
Merged
feat: hardcode legacy_user_permissions has_trialed to be true#1709whutchinson98 merged 1 commit intomainfrom
whutchinson98 merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to query whether the user has trialed or not via stripe every call. This is no longer needed though as we don't actually support trialing anymore when you go to checkout.
So the slowdown due to stripe + actually using the has_trialed boolean gives us a slow api call and misleading text on the frontend.
If we ever plan to setup trials again, we should store this information on the
macro_useror in some join table as that will be a much faster lookup than stripe api.In dev, when having to check stripe my call is ~200ms. When I ignore stripe it's ~40ms.
Misleading "early member for free text":
Actual stripe checkout we get sent to that is not for a free trial: