fix(email): Draft re-appears after send#1800
Merged
evanhutnik merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
undoReplySnapshot) persisting at module level and being auto-restored on remount.await executeSaveDraft()before sending to guarantee a draft ID always exists.onClickheld a closure over the old component instance, so clicking undo after navigating away and back would unsend the message but fail to restore the compose box. Introduced a module-levelrestoreUndoCallbackthat the current component registers, allowing stale closures to reach the live component.Changes
undoReplySnapshotinto two module-level variables:undoSendSnapshot(set on send, consumed by undo) andundoReplySnapshot(only set by undo for inline reply remount)restoreUndoCallbackpattern so undo-send works correctly across component remountssetTimeoutto let reactive updates fromsetQueryDatasettle before restoring attachmentsexecuteSaveDraft()call in the scheduled send path since draft is now always saved before send