Fix sidebar toggle hotkey when editor input is focused#1944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
cmd+.sidebar toggle did not fire when focus was inside markdown/editable inputs, preventing quick sidebar toggling from editor contexts.Description
registerSidebarHotkeyshelper that acceptsisSlim,onOpenChange, andopenWithSplitto separate concerns and make behavior testable.cmd+.registration to setrunWithInputFocused: trueso the toggle runs even when input/editable elements are focused.AppSidebarto callregisterSidebarHotkeysinstead of inline registrations.js/app/packages/app/component/app-sidebar/sidebar.test.tsto assert thecmd+.registration includesrunWithInputFocused: trueand that the toggle handler reads the current slim state and callsonOpenChangeaccordingly.Testing
packages/app/component/app-sidebar/sidebar.test.tsand attempted to run it withbun run test -- packages/app/component/app-sidebar/sidebar.test.ts -c packages/app, but the run failed in this environment due to dependency resolution (vitestfetch returned a 403 from the npm registry), so tests were not executed here.runWithInputFocusedflag is set and the toggle handler callsonOpenChange(isSlim())as intended.Codex Task