Skip to content

Fix notification-triggered search reloads and sidebar flicker#1981

Merged
gbirman merged 6 commits intomainfrom
gab/fix/notification-search-reload
Mar 16, 2026
Merged

Fix notification-triggered search reloads and sidebar flicker#1981
gbirman merged 6 commits intomainfrom
gab/fix/notification-search-reload

Conversation

@gbirman
Copy link
Copy Markdown
Contributor

@gbirman gbirman commented Mar 16, 2026

Summary

  • Narrowed soup query invalidation on notifications: Channel and document notification handlers now use refetchSoupEntity + invalidateSoupEntity (per-entity) instead of invalidating all soup queries via soupKeys._def. This prevents incoming notifications from retriggering unrelated search requests.
  • Stabilized unread channel ordering in sidebar: The unread channels list now maintains a stable order — channels only reposition when they enter/leave the unread set, not when notification counts update during refetches.
  • Filtered out currently-viewed channels from unread list: Channels open in any split are excluded from the unread widget, preventing the brief flash of unread 1 when receiving a notification in a channel you are already viewing.

@gbirman gbirman requested a review from a team as a code owner March 16, 2026 21:06
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 16, 2026

@gbirman gbirman merged commit b4b9b6f into main Mar 16, 2026
22 checks passed
@gbirman gbirman deleted the gab/fix/notification-search-reload branch March 16, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant