Skip to content

fix[mobile]: fix channel soup truncation#2080

Merged
peterchinman merged 3 commits intomainfrom
peter/fix-message-truncation
Mar 20, 2026
Merged

fix[mobile]: fix channel soup truncation#2080
peterchinman merged 3 commits intomainfrom
peter/fix-message-truncation

Conversation

@peterchinman
Copy link
Copy Markdown
Contributor

@peterchinman peterchinman commented Mar 20, 2026

also fixes re-introduction of mobile sidebar bug

Summary by CodeRabbit

  • New Features

    • Channel messages now display the sender's name before the message content, providing better context
  • Style

    • Sidebar is hidden on mobile devices to optimize limited screen space
    • Markdown text styling updated for consistent font weight treatment across the application

@peterchinman peterchinman requested a review from a team as a code owner March 20, 2026 16:57
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 20, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9c375fa8-2aa7-488c-a086-0be7ecd64aaa

📥 Commits

Reviewing files that changed from the base of the PR and between e32a9d4 and 7b39478.

📒 Files selected for processing (3)
  • js/app/packages/app/component/Layout.tsx
  • js/app/packages/core/component/LexicalMarkdown/theme.ts
  • js/app/packages/entity/src/composed/ListEntity.tsx

📝 Walkthrough

Walkthrough

Sidebar rendering now requires non-mobile clients; markdown clamp theme explicitly sets bold text to font-medium; channel latest-message rendering prepends the sender's first name (when available) and uses singleLine for the markdown render.

Changes

Cohort / File(s) Summary
Sidebar Visibility Logic
js/app/packages/app/component/Layout.tsx
Tightened AppSidebar render condition to also require !isMobile() (in addition to existing auth/path checks).
Theming Configuration
js/app/packages/core/component/LexicalMarkdown/theme.ts
Added explicit text entry to twoLineClampMarkdownTheme: { ...theme.text, bold: 'font-medium' }.
Message Display Enhancement
js/app/packages/entity/src/composed/ListEntity.tsx
Compute sender display name from latestMessage.senderId via utilities, prepend sender's first name in bold to channel latest-message markdown when present, and add singleLine prop to StaticMarkdown instance.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐇 I hopped through code with nimble feet,
Sidebar rests where mobiles meet,
Boldened lines now softly hum,
Names lean in before the thrum,
A tiny rabbit cheers—well done! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch peter/fix-message-truncation

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 20, 2026

@peterchinman peterchinman merged commit 08ffe2e into main Mar 20, 2026
22 checks passed
@peterchinman peterchinman deleted the peter/fix-message-truncation branch March 20, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant