Skip to content

feat(new-channels): add backspace hotkey for delete + fix full width edit message input#2102

Merged
synoet merged 1 commit intomainfrom
synoet/new-channels-backspace-hotkey
Mar 22, 2026
Merged

feat(new-channels): add backspace hotkey for delete + fix full width edit message input#2102
synoet merged 1 commit intomainfrom
synoet/new-channels-backspace-hotkey

Conversation

@synoet
Copy link
Copy Markdown
Contributor

@synoet synoet commented Mar 22, 2026

  • add hotkey for deleting a message
  • fix width on collapsed message inline message editor

@synoet synoet requested a review from a team as a code owner March 22, 2026 02:29
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 22, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: bbcfb6a3-9195-4053-8560-c556eeecfb2a

📥 Commits

Reviewing files that changed from the base of the PR and between 39c4c20 and e6b21be.

📒 Files selected for processing (5)
  • js/app/packages/channel/Channel/InlineMessageEditor.tsx
  • js/app/packages/channel/Channel/create-channel-hotkeys.ts
  • js/app/packages/channel/Message/ChannelMessage.tsx
  • js/app/packages/channel/Thread/create-thread-hotkeys.ts
  • js/app/packages/core/hotkey/tokens.ts

Walkthrough

This pull request extends message and thread reply management by adding delete hotkey functionality and improving component styling. The MessageEditorContent component now accepts an optional class prop for custom styling. Two hotkey condition predicates were renamed to reflect broader usage: canEditSelectedMessageFromHotkeycanEditOrDeleteSelectedMessageFromHotkey and canEditThreadReplyFromHotkeycanEditOrDeleteThreadReplyFromHotkey. New backspace hotkey registrations were added for both channel messages and thread replies, each invoking delete actions when conditions are met. Supporting hotkey tokens channel.deleteMessage and channel.threadDeleteReply were registered.

Poem

🐰 A rabbit hops with joy today,
Delete keys now light the way!
Messages vanish with a tap,
Classes flow through styling's gap,
Hotkeys sing in harmony—
Edit, delete, wild and free! 🌿

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided by the author; the description is completely empty. Provide a description explaining the motivation, implementation details, and any breaking changes or considerations for reviewers.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the two main changes: adding backspace hotkey for delete functionality and fixing full-width edit message input styling.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch synoet/new-channels-backspace-hotkey

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

@synoet synoet merged commit e9dea08 into main Mar 22, 2026
23 of 24 checks passed
@synoet synoet deleted the synoet/new-channels-backspace-hotkey branch March 22, 2026 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant