Skip to content

refactor(gmail_client): remove explicit level attrs from tracing instruments#2114

Merged
evanhutnik merged 1 commit intomainfrom
evan/remove-gmail-level-attrs
Mar 23, 2026
Merged

refactor(gmail_client): remove explicit level attrs from tracing instruments#2114
evanhutnik merged 1 commit intomainfrom
evan/remove-gmail-level-attrs

Conversation

@evanhutnik
Copy link
Copy Markdown
Contributor

Summary

  • Removes all explicit level = "info" and level = "debug" attributes from #[tracing::instrument] macros in the gmail_client crate
  • Lets tracing use default levels instead of overriding them per-function
  • Affects 6 instrument annotations across lib.rs, labels.rs, threads.rs, and profile.rs

Test plan

  • cargo check -p gmail_client passes
  • CI passes

🤖 Generated with Claude Code

…ruments

Let tracing use default levels instead of explicitly setting info/debug
on instrument macros throughout the gmail_client crate.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: baa6f288-c80a-42f1-96d9-9facf61ed7b6

📥 Commits

Reviewing files that changed from the base of the PR and between f4324fe and 5935024.

📒 Files selected for processing (4)
  • rust/cloud-storage/gmail_client/src/labels.rs
  • rust/cloud-storage/gmail_client/src/lib.rs
  • rust/cloud-storage/gmail_client/src/profile.rs
  • rust/cloud-storage/gmail_client/src/threads.rs
💤 Files with no reviewable changes (1)
  • rust/cloud-storage/gmail_client/src/labels.rs

Walkthrough

This pull request removes explicit log-level configurations from tracing instrumentation attributes across four files in the gmail_client module. The #[tracing::instrument] macros on modify_message_labels, delete_gmail_label, batch_modify_labels, get_profile_threads_total, and get_threads_with_retry are updated to eliminate their level parameters (either "debug" or "info"). The functions' logic, public signatures, and other instrumentation parameters remain unchanged. This allows the tracing framework to use its default log levels instead of explicit overrides.

Poem

🐰 Trace levels fall away like morning dew,
Default paths now guide our debugging through,
No explicit levels—just the span's own way,
Cleaner code hops forward into the day!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: removing explicit level attributes from tracing instrument macros in the gmail_client crate.
Description check ✅ Passed The description is directly related to the changeset, clearly explaining what was removed and why (letting tracing use default levels), with specific file references and a test plan.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch evan/remove-gmail-level-attrs

Comment @coderabbitai help to get the list of available commands and usage tips.

@evanhutnik evanhutnik merged commit 2f40061 into main Mar 23, 2026
40 checks passed
@evanhutnik evanhutnik deleted the evan/remove-gmail-level-attrs branch March 23, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant