Skip to content

fix(properties): only update task status property when updating task status#2121

Merged
whutchinson98 merged 1 commit intomainfrom
hutch/macro-cykkt7pNDSPNoyHWMM9X3-github-sync-app-is-causing-tasks-to-be-hidden-after-updating-from-pr
Mar 23, 2026
Merged

fix(properties): only update task status property when updating task status#2121
whutchinson98 merged 1 commit intomainfrom
hutch/macro-cykkt7pNDSPNoyHWMM9X3-github-sync-app-is-causing-tasks-to-be-hidden-after-updating-from-pr

Conversation

@whutchinson98
Copy link
Copy Markdown
Member

No description provided.

@whutchinson98 whutchinson98 requested a review from a team as a code owner March 23, 2026 17:05
@ghost
Copy link
Copy Markdown

ghost commented Mar 23, 2026

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 76ecbc2b-1431-43fc-bdf5-f8532f59e8ec

📥 Commits

Reviewing files that changed from the base of the PR and between 04750b5 and 8929cf7.

📒 Files selected for processing (2)
  • rust/cloud-storage/system_properties/.sqlx/query-8d21bf0aa4c20589a55cf5777aa9c658fdacea4d0d0c7070aded12cccd373911.json
  • rust/cloud-storage/system_properties/src/outbound/pgpool/mod.rs

Walkthrough

An UPDATE query for entity_properties in the cloud storage system properties module has been narrowed to include an additional constraint. Previously, the query matched only on entity_id, potentially updating multiple property rows. The revised query now requires both entity_id and property_definition_id to match before performing the update. The corresponding Rust implementation in mod.rs has been updated to pass a third parameter containing the property definition ID. The SQLx query metadata file has been updated to reflect the modified SQL statement and adjusted parameter declarations.

Poem

🐰 A query once broad, now precise and true,
With two checks instead of just one to pursue,
The property lands where it's meant to be,
No more wayward updates wild and free,
Specificity blooms in our SQL tree! 🌟

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author; the description is empty. Add a description explaining the bug being fixed and why the additional constraint was necessary to prevent unintended property updates.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title accurately describes the main change: adding a constraint to only update the task status property when the property_definition_id matches the status property.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hutch/macro-cykkt7pNDSPNoyHWMM9X3-github-sync-app-is-causing-tasks-to-be-hidden-after-updating-from-pr

Comment @coderabbitai help to get the list of available commands and usage tips.

@whutchinson98 whutchinson98 merged commit aad1e6a into main Mar 23, 2026
40 checks passed
@whutchinson98 whutchinson98 deleted the hutch/macro-cykkt7pNDSPNoyHWMM9X3-github-sync-app-is-causing-tasks-to-be-hidden-after-updating-from-pr branch March 23, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant