Skip to content

chg(new-chanenls): temp disable overide#2136

Merged
synoet merged 1 commit intomainfrom
synoet/temp-disable-overide
Mar 23, 2026
Merged

chg(new-chanenls): temp disable overide#2136
synoet merged 1 commit intomainfrom
synoet/temp-disable-overide

Conversation

@synoet
Copy link
Copy Markdown
Contributor

@synoet synoet commented Mar 23, 2026

No description provided.

@synoet synoet requested a review from a team as a code owner March 23, 2026 22:41
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 23, 2026

Walkthrough

The ChannelBlockSwitch.tsx component had its feature-flag dependency commented out. The import statement for ENABLE_NEW_CHANNELS from the feature flags module and its associated override prop in the ShowFeatureFlag component were disabled. The component now relies solely on the fallback render behavior of ShowFeatureFlag instead of the computed feature flag override.

Poem

🐰 A flag has rested in silence today,
Override disabled, it hops away,
Fallback behavior takes up the lead,
Simplified logic—just what we need!
The component breathes easier now. ✨

🚥 Pre-merge checks | ❌ 3

❌ Failed checks (1 warning, 2 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title contains a typo ('chanenls' instead of 'channels') and uses vague phrasing ('temp disable overide') that doesn't clearly convey the purpose of temporarily disabling the feature flag override. Clarify the title by fixing typos and being more specific, e.g., 'Temporarily disable ENABLE_NEW_CHANNELS override in ChannelBlockSwitch' or similar.
Description check ❓ Inconclusive No pull request description was provided, making it impossible to assess whether the author explained the rationale or context for this temporary change. Add a description explaining why the feature flag override is being temporarily disabled and any related context or follow-up actions needed.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch synoet/temp-disable-overide

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@js/app/packages/block-channel/component/ChannelBlockSwitch.tsx`:
- Line 2: Remove the dead commented feature-flag code from the
ChannelBlockSwitch component: delete the commented import line for
ENABLE_NEW_CHANNELS and any other commented lines related to that flag inside
the ChannelBlockSwitch.tsx file (e.g., the commented code at line 11). Ensure
there are no leftover commented references to ENABLE_NEW_CHANNELS in the
ChannelBlockSwitch component or its surrounding logic so the file contains only
active, intentional code.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 42e01296-478a-40a3-94c4-d716036bad95

📥 Commits

Reviewing files that changed from the base of the PR and between 7bbe20a and 11c62c8.

📒 Files selected for processing (1)
  • js/app/packages/block-channel/component/ChannelBlockSwitch.tsx

@synoet synoet merged commit 9118029 into main Mar 23, 2026
26 checks passed
@synoet synoet deleted the synoet/temp-disable-overide branch March 23, 2026 22:45
synoet added a commit that referenced this pull request Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant