Skip to content

feat(icon): Update share icon#2152

Merged
aidanhb merged 1 commit intomainfrom
aidan/share-icon
Mar 24, 2026
Merged

feat(icon): Update share icon#2152
aidanhb merged 1 commit intomainfrom
aidan/share-icon

Conversation

@aidanhb
Copy link
Copy Markdown
Contributor

@aidanhb aidanhb commented Mar 24, 2026

No description provided.

@aidanhb aidanhb requested a review from a team as a code owner March 24, 2026 18:10
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 61ecbbf1-7b05-4fdf-879d-86d5dfd0b1de

📥 Commits

Reviewing files that changed from the base of the PR and between 01efe78 and daea8bf.

⛔ Files ignored due to path filters (2)
  • js/app/packages/macro-icons/wide/share.svg is excluded by !**/*.svg
  • js/app/packages/macro-icons/wide/users.svg is excluded by !**/*.svg
📒 Files selected for processing (13)
  • js/app/packages/block-canvas/component/TopBar.tsx
  • js/app/packages/block-chat/component/TopBar.tsx
  • js/app/packages/block-code/component/TopBar.tsx
  • js/app/packages/block-email/component/TopBar.tsx
  • js/app/packages/block-image/component/TopBar.tsx
  • js/app/packages/block-md/component/TopBar.tsx
  • js/app/packages/block-pdf/component/TopBar.tsx
  • js/app/packages/block-project/component/TopBar.tsx
  • js/app/packages/block-unknown/component/Block.tsx
  • js/app/packages/block-unknown/component/TopBar.tsx
  • js/app/packages/block-video/component/TopBar.tsx
  • js/app/packages/core/component/TopBar/ShareButton.tsx
  • js/app/packages/macro-icons/wide/animating/users.tsx

Walkthrough

This pull request updates the Share icon asset across multiple TopBar components in block packages, switching from @icon/regular/share.svg to @macro-icons/wide/share.svg. The ShareButton component is simplified to render a single shared icon instead of conditionally rendering different icons based on access level states. Additionally, the AnimatedShareIcon component in the macro-icons package is renamed to AnimatedUsersIcon with corresponding CSS class and selector updates.

Poem

🐰 Hops excitedly

Wide icons now dance across the blocks,
No more switching locks and socks!
One share button, simple and true,
AnimatedUsersIcon in the avenue. ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to evaluate whether it relates to the changeset. Consider adding a description explaining the motivation for updating the share icon asset and any visual or design implications of switching to the wide variant.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Update share icon' accurately summarizes the main change: replacing the share icon asset across multiple components from the regular version to a macro-icons wide version.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch aidan/share-icon

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

@aidanhb aidanhb merged commit a335317 into main Mar 24, 2026
24 checks passed
@aidanhb aidanhb deleted the aidan/share-icon branch March 24, 2026 18:17
@coderabbitai coderabbitai bot mentioned this pull request Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant