fix(cursor): define cursor styles so it can change#2154
Conversation
WalkthroughThe pull request adds 14 CSS custom properties to the Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@js/app/packages/app/index.css`:
- Around line 260-272: SelectionRenderer.tsx uses var(--cursor-nwse-resize) and
var(--cursor-nesw-resize) but those CSS custom properties are missing; update
the CSS variables block in index.css (the cursor variables section) to declare
--cursor-nwse-resize and --cursor-nesw-resize with values "nwse-resize" and
"nesw-resize" respectively so the diagonal resize cursors are applied
consistently across the app.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: cae26c79-53a1-44b4-8511-4751f2e736c8
📒 Files selected for processing (1)
js/app/packages/app/index.css
js/app/packages/app/index.css
Outdated
| /* Cursor variables — override these to use custom cursors */ | ||
| --cursor-auto: auto; | ||
| --cursor-default: default; | ||
| --cursor-pointer: pointer; |
There was a problem hiding this comment.
can we make this "default" default for now. would be a decent way of forcing the constant claude slop "cursor-pointer" to not show pointer for now
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@js/app/packages/app/index.css`:
- Line 263: The CSS variable --cursor-pointer is set to default (a temporary
override) which mismatches its name; update the declaration for --cursor-pointer
in index.css by adding a concise inline comment explaining this is an
intentional temporary pointer->default mapping and why, and optionally rename
the variable to a clearer name (e.g., --cursor-default-override or
--cursor-pointer-disabled) and update all usages of --cursor-pointer accordingly
so the intent is explicit to future maintainers.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 02ddba2e-1da4-4770-b841-1f30f394f4a2
📒 Files selected for processing (1)
js/app/packages/app/index.css
| /* Cursor variables — override these to use custom cursors */ | ||
| --cursor-auto: auto; | ||
| --cursor-default: default; | ||
| --cursor-pointer: default; |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Document the temporary pointer-to-default mapping.
The --cursor-pointer variable is set to default instead of pointer, creating a semantic mismatch between the variable name and its value. While this appears intentional as a temporary workaround, it could confuse future developers who expect var(--cursor-pointer) to display a pointer cursor.
📝 Suggested documentation
Add an inline comment explaining the temporary nature of this mapping:
- --cursor-pointer: default;
+ --cursor-pointer: default; /* TODO: Temporary - prevents unwanted pointer cursors in generated code */Alternatively, consider using a more explicit variable name like --cursor-default-override or --cursor-pointer-disabled to make the intention clearer.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| --cursor-pointer: default; | |
| --cursor-pointer: default; /* TODO: Temporary - prevents unwanted pointer cursors in generated code */ |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@js/app/packages/app/index.css` at line 263, The CSS variable --cursor-pointer
is set to default (a temporary override) which mismatches its name; update the
declaration for --cursor-pointer in index.css by adding a concise inline comment
explaining this is an intentional temporary pointer->default mapping and why,
and optionally rename the variable to a clearer name (e.g.,
--cursor-default-override or --cursor-pointer-disabled) and update all usages of
--cursor-pointer accordingly so the intent is explicit to future maintainers.
2 participants
Allows cursor to change based on styling. Fixes bug where cursor wasn't changing on resize gutter hover.