Skip to content

fix(search): add doc storage url env var to upload lambda#2157

Merged
gbirman merged 1 commit intomainfrom
gab/fix/search-upload-handler
Mar 24, 2026
Merged

fix(search): add doc storage url env var to upload lambda#2157
gbirman merged 1 commit intomainfrom
gab/fix/search-upload-handler

Conversation

@gbirman
Copy link
Copy Markdown
Contributor

@gbirman gbirman commented Mar 24, 2026

already ran this locally to fix dev, there's gonna be a few missing items im not gonna backfill.

@gbirman gbirman requested a review from a team as a code owner March 24, 2026 21:03
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 24, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 7b6491e8-df54-45bd-b756-a93eca267715

📥 Commits

Reviewing files that changed from the base of the PR and between f53e406 and a07f228.

📒 Files selected for processing (2)
  • infra/stacks/search-upload/index.ts
  • infra/stacks/search-upload/search-upload-lambda.ts

Walkthrough

The search-upload infrastructure was updated to support document storage service integration. A new environment variable DOCUMENT_STORAGE_SERVICE_URL was added to the SearchUploadHandler lambda function. The variable uses environment-specific URLs: the production stack receives https://cloud-storage.macro.com, while non-production stacks receive https://cloud-storage-${stack}.macro.com. The corresponding lambda type definition was updated to include this new required environment variable in the EnvVars configuration contract.

Poem

🐰 A storage service path takes flight,
Through lambda lands of code and might,
For prod and test, the URLs align,
Environment variables, oh so fine!
The rabbit hops with joy so bright,
As documents find their home just right! 🎉

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gab/fix/search-upload-handler

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the infra label Mar 24, 2026
@gbirman gbirman merged commit 50ce720 into main Mar 24, 2026
22 of 23 checks passed
@gbirman gbirman deleted the gab/fix/search-upload-handler branch March 24, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant