Skip to content

feat(new-chanenls): remove raf, lower buffer#2162

Merged
synoet merged 3 commits intomainfrom
synoet/new-channels-remove-raf-lower-buffer
Mar 24, 2026
Merged

feat(new-chanenls): remove raf, lower buffer#2162
synoet merged 3 commits intomainfrom
synoet/new-channels-remove-raf-lower-buffer

Conversation

@synoet
Copy link
Copy Markdown
Contributor

@synoet synoet commented Mar 24, 2026

  • chore(new-channels): remove raf lower buffer
  • format

@synoet synoet requested a review from a team as a code owner March 24, 2026 23:01
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 24, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

Changes were made to two channel-related components. In ThreadList.tsx, the BASE_ITEM_SIZE constant was updated from 62 to 64, the BASE_BUFFER_SIZE calculation was simplified, and the initial scroll behavior was refactored to perform a single immediate scroll operation instead of multiple nested passes. The scroll handler now logs a warning when the virtualizer handle returns undefined, and a flex spacer element was added to the scroll container. In ChannelThread.tsx, an empty line was removed between two variable declarations with no functional impact.

Poem

🐰 A rabbit bounced with glee today,
As spacing grew and scroll improved the way,
One fewer line, one buffered space,
Makes threads load with steadier grace!
Constants tuned, with warnings clear,
Simplicity brings us all good cheer! 🌿

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: removing nested requestAnimationFrame passes and lowering the buffer size from BASE_ITEM_SIZE * 10 to BASE_ITEM_SIZE.
Description check ✅ Passed The description is related to the changeset, mentioning the removal of RAF (requestAnimationFrame) and buffer lowering, which aligns with the actual changes made.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch synoet/new-channels-remove-raf-lower-buffer

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

@synoet synoet merged commit 0bddea7 into main Mar 24, 2026
22 of 23 checks passed
@synoet synoet deleted the synoet/new-channels-remove-raf-lower-buffer branch March 24, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant