Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (45)
💤 Files with no reviewable changes (43)
WalkthroughThis PR removes many dependency entries across multiple package.json files, deletes numerous Storybook configuration and story files, and eliminates several feature implementations and utilities (including Mermaid rendering, the Markdown component, ThreeWireframe, and related mermaid utility code). It also updates build chunking configuration by removing three.js from manualChunks and adjusts workspace entries for Storybook. Several package manifests and dev tooling configs were simplified and trailing newlines added where noted. Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@js/app/packages/app/package.json`:
- Around line 27-30: The package.json currently omits the three dependency while
component/auth/ThreeWireframe.tsx still imports three and addons (symbols:
import * as THREE, isWebGL2Available, OrbitControls, GLTFLoader), causing
resolution errors; either add "three" back into js/app/packages/app/package.json
dependencies (pin to the project’s agreed version) and run install, or
remove/replace the three-related imports and any usage in ThreeWireframe.tsx
(and any consumers) so the component no longer references THREE,
isWebGL2Available, OrbitControls, or GLTFLoader.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: a7089132-499c-43ac-a6a1-5ea1d3325d5a
⛔ Files ignored due to path filters (1)
js/app/bun.lockis excluded by!**/*.lock
📒 Files selected for processing (14)
js/app/package.jsonjs/app/packages/analytics/package.jsonjs/app/packages/app/package.jsonjs/app/packages/app/vite.base.tsjs/app/packages/block-canvas/component/CanvasController.tsxjs/app/packages/block-canvas/definition.tsjs/app/packages/block-canvas/util/mermaid.tsjs/app/packages/block-chat/package.jsonjs/app/packages/block-pdf/package.jsonjs/app/packages/core/package.jsonjs/app/packages/filesystem/package.jsonjs/app/packages/macro-entity/package.jsonjs/app/packages/tauri/package.jsonjs/app/packages/ui/package.json
💤 Files with no reviewable changes (9)
- js/app/packages/block-canvas/definition.ts
- js/app/packages/tauri/package.json
- js/app/packages/analytics/package.json
- js/app/packages/app/vite.base.ts
- js/app/packages/filesystem/package.json
- js/app/packages/ui/package.json
- js/app/packages/block-pdf/package.json
- js/app/packages/block-canvas/component/CanvasController.tsx
- js/app/packages/block-canvas/util/mermaid.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.