fix[soup]: allow multiple inbox fiters to be applied

[peterchinman]

No description provided.

[coderabbitai]

Walkthrough

The SOUP_FILTER_GROUPS configuration in the filters module was modified to enable multiple concurrent selections for the entity-type filter group. The allowMultiple property was changed from false to true for this specific filter group, allowing users to select multiple entity types simultaneously. All other filter definitions and configurations remain unaffected by this single-line modification.

Poem

🐰 With a hop and a bound, our filters now shine bright,
Multi-selections bloom, what a delightful sight!
Entity types dance together in harmony,
No longer confined to just one, now finally free! ✨
A rabbit's delight, configuration's new might!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to assess relevance to the changeset.	Add a pull request description explaining the motivation and context for allowing multiple entity-type filter selections.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title describes enabling multiple filter selections, which aligns with the core change of setting allowMultiple to true for the entity-type filter.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch peter/select-multiple-inbox-type-filters

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Preview: https://peter-select-multiple-inbox-ty-fcdolz.preview.macro.com/app (b778cf4)

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

js/app/packages/app/component/next-soup/filters/configs.ts (1)

417-425: ⚠️ Potential issue | 🟡 Minor

Update the JSDoc comment to reflect the new behavior.

The comment on line 420 states 'entity-type': Mutually exclusive by default, but with allowMultiple: true, this group is no longer mutually exclusive. The comment should be updated to avoid misleading future developers.

📝 Proposed fix

 /**
  * Default filter group configurations for soup filters.
  * - 'focus': Mutually exclusive (signal/noise/explicit-noise)
- * - 'entity-type': Mutually exclusive by default
+ * - 'entity-type': Allows multiple selections
  */
 export const SOUP_FILTER_GROUPS: FilterGroupConfig[] = [
   { id: 'focus', allowMultiple: false },
   { id: 'entity-type', allowMultiple: true },
 ];

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@js/app/packages/app/component/next-soup/filters/configs.ts` around lines 417
- 425, Update the JSDoc above SOUP_FILTER_GROUPS to reflect the current
behavior: change the line that says "'entity-type': Mutually exclusive by
default" to indicate that 'entity-type' allows multiple selections (e.g.,
"allows multiple selections" or "not mutually exclusive") because the
SOUP_FILTER_GROUPS entry for 'entity-type' sets allowMultiple: true; keep the
note for 'focus' as mutually exclusive to match its allowMultiple: false.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@js/app/packages/app/component/next-soup/filters/configs.ts`:
- Around line 417-425: Update the JSDoc above SOUP_FILTER_GROUPS to reflect the
current behavior: change the line that says "'entity-type': Mutually exclusive
by default" to indicate that 'entity-type' allows multiple selections (e.g.,
"allows multiple selections" or "not mutually exclusive") because the
SOUP_FILTER_GROUPS entry for 'entity-type' sets allowMultiple: true; keep the
note for 'focus' as mutually exclusive to match its allowMultiple: false.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 38bdaade-7b12-4f4f-8306-47bf06610f70

📥 Commits

Reviewing files that changed from the base of the PR and between a6708c9 and 17f7f3e.

📒 Files selected for processing (1)

• js/app/packages/app/component/next-soup/filters/configs.ts