Skip to content

fix(analytics): same hotkey events firing too often#2186

Merged
dev-rb merged 2 commits intomainfrom
rahul/fix-analytics-hotkey-events-firing-too-often
Mar 25, 2026
Merged

fix(analytics): same hotkey events firing too often#2186
dev-rb merged 2 commits intomainfrom
rahul/fix-analytics-hotkey-events-firing-too-often

Conversation

@dev-rb
Copy link
Copy Markdown
Contributor

@dev-rb dev-rb commented Mar 25, 2026

No description provided.

@dev-rb dev-rb requested a review from a team as a code owner March 25, 2026 19:47
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: dd0a3eb7-ea99-4a65-b052-fb0af831ff17

📥 Commits

Reviewing files that changed from the base of the PR and between abb324e and fb7d37c.

📒 Files selected for processing (1)
  • js/app/packages/app/component/GlobalHotkeys.tsx

Walkthrough

This pull request modifies the GlobalHotkeys component to refine analytics event tracking for hotkey presses. It introduces debouncing logic to prevent redundant tracking events when the same hotkey sequence fires repeatedly. The change adds debouncedTrack functionality with a 250ms debounce interval, includes the pressed keys string in analytics payloads, tracks the last fired sequence using lastFired state, and implements proper cleanup to clear pending debounced events when the component is disposed.

Poem

🐰 A rabbit hops through hotkeys bright,
Debounce smooths the tracking flight,
No more rapid-fire blasts,
Just gentle analytics that last,
Keys pressed clean—what a delight!

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to evaluate whether the description relates to the changeset. Add a description explaining the problem (hotkey events firing too often) and the solution (debouncing) to provide context for reviewers.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: fixing an issue where the same hotkey analytics events are firing too frequently, which aligns with the implementation of debouncing logic in the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rahul/fix-analytics-hotkey-events-firing-too-often

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

@dev-rb dev-rb merged commit cee69bc into main Mar 25, 2026
23 checks passed
@dev-rb dev-rb deleted the rahul/fix-analytics-hotkey-events-firing-too-often branch March 25, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant