Skip to content

feat(new-channels): nit styling improvements#2194

Merged
synoet merged 1 commit intomainfrom
synoet/new-channels-nit-styling
Mar 25, 2026
Merged

feat(new-channels): nit styling improvements#2194
synoet merged 1 commit intomainfrom
synoet/new-channels-nit-styling

Conversation

@synoet
Copy link
Copy Markdown
Contributor

@synoet synoet commented Mar 25, 2026

No description provided.

@synoet synoet requested a review from a team as a code owner March 25, 2026 21:43
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: de61cc63-a1dd-49b3-9a9e-1ad5925b625b

📥 Commits

Reviewing files that changed from the base of the PR and between 0d855ed and 5a1bf7f.

📒 Files selected for processing (4)
  • js/app/packages/channel/Message/ChannelMessage.tsx
  • js/app/packages/channel/Message/EditedIndicator.tsx
  • js/app/packages/channel/Message/SenderName.tsx
  • js/app/packages/channel/Message/Timestamp.tsx

📝 Walkthrough

Summary by CodeRabbit

  • Style
    • Refined message header spacing for a more compact layout.
    • Updated text colors and typography across message components for improved visual consistency and readability.

Walkthrough

Updates styling across message display components: reduces header spacing, adjusts font weights from semibold to medium, and replaces secondary color classes with placeholder color variants for consistency.

Changes

Cohort / File(s) Summary
Color scheme updates
EditedIndicator.tsx, Timestamp.tsx
Replaced text-secondary-fg with text-ink-placeholder class for the "(edited)" label and timestamp styling.
Typography updates
SenderName.tsx
Changed sender name font weight from font-semibold to font-medium.
Layout spacing adjustments
ChannelMessage.tsx
Reduced header container gap from gap-2 to gap-1 and removed mt-0.5 top margin from regular message content.

Possibly related PRs

  • macro#2080: Updates markdown bold styling to use font-medium, aligning with the font-weight changes applied to sender name in this PR.
🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided; however, the changes are minor styling adjustments (CSS class updates) across message components that are contextually clear from the file changes and title. Consider adding a brief description explaining the rationale behind these styling changes, such as visual consistency improvements or design system alignment.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title follows conventional commits format with 'feat:' prefix, includes the scope 'new-channels', is under 72 characters (44 characters), and accurately describes the styling improvements made across multiple message components.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

@synoet synoet merged commit c53a580 into main Mar 25, 2026
23 checks passed
@synoet synoet deleted the synoet/new-channels-nit-styling branch March 25, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant