Skip to content

fix(new-channels): remove persistence for thread-replies#2197

Merged
synoet merged 1 commit intomainfrom
synoet/new-channels-disable-thread-reply-persistence
Mar 25, 2026
Merged

fix(new-channels): remove persistence for thread-replies#2197
synoet merged 1 commit intomainfrom
synoet/new-channels-disable-thread-reply-persistence

Conversation

@synoet
Copy link
Copy Markdown
Contributor

@synoet synoet commented Mar 25, 2026

No description provided.

@synoet synoet requested a review from a team as a code owner March 25, 2026 22:12
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 25, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: fe689a5f-dc02-49eb-9738-ffc3d68f2c56

📥 Commits

Reviewing files that changed from the base of the PR and between d704bf3 and 6f42ab7.

📒 Files selected for processing (2)
  • js/app/packages/queries/client.ts
  • js/app/packages/queries/persistence-scopes.ts
💤 Files with no reviewable changes (1)
  • js/app/packages/queries/persistence-scopes.ts

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Refined local data caching behavior by adjusting which information is stored for offline access and removing legacy storage cleanup routines.

Walkthrough

This PR removes legacy IndexedDB cleanup logic from the persistence initialization and disables persistence for specific channel query types including attachments, participants, and threadReplies. It also removes the unused createPersistenceKey import from the client setup.

Changes

Cohort / File(s) Summary
Legacy Persistence Cleanup
js/app/packages/queries/client.ts
Removed inline IndexedDB cleanup logic that deleted legacy "v0" persistence databases (channels and email-threads) and removed the unused createPersistenceKey import.
Query Persistence Configuration
js/app/packages/queries/persistence-scopes.ts
Removed channel query prefixes for attachments, participants, and threadReplies from the persisted query set, disabling persistence for these query types.

Possibly related PRs

🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess if the description relates to the changeset. Add a pull request description that explains the rationale for removing persistence for thread-replies and any related context or implications of this change.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title follows conventional commits format with 'fix:' prefix and is 56 characters, well under the 72-character limit, clearly summarizing the main change of removing thread-replies persistence.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

@synoet synoet merged commit 9a20001 into main Mar 25, 2026
22 of 23 checks passed
@synoet synoet deleted the synoet/new-channels-disable-thread-reply-persistence branch March 25, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant