feat[mobile]: soup filters as drawer#2229
Merged
peterchinman merged 13 commits intomainfrom Mar 27, 2026
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdds a mobile bottom-sheet filter UI and related type/prop adjustments: new Changes
Possibly related PRs
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
peterchinman
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@js/app/packages/app/component/next-soup/soup-view/filters-bar/mobile-filter-drawer.tsx`:
- Around line 62-64: The toggleFilter call casts optionId to FilterID to silence
a mismatch—remove that cast and fix the source types so FilterOption.id is
strongly typed as FilterID (or introduce a typed category/value object) so only
valid FilterIDs flow into soup.filters.toggle; update the FilterOption type
definition (and any factories/creators that construct option ids) to return
FilterID instead of string, then remove the `as FilterID` in toggleFilter and
other similar sites so the type system enforces correctness when calling
soup.filters.toggle.
In `@js/app/packages/app/component/next-soup/soup-view/soup-view.tsx`:
- Around line 651-669: The current init block skips applying
props.initialClientFilters when persistenceDisabled is true, so ensure
initialClientFilters are applied regardless of persistence state: after checking
persistenceDisabled and reading persistedState, if no persisted initial is
applied (or persistenceDisabled is true) and props.initialClientFilters exists
then call soup.filters.set(props.initialClientFilters) (and any equivalent
client-side initializations that the persisted path would set) — update the
logic around persistenceDisabled, persistedState, props.initialClientFilters and
the soup.filters.set / setQueryFilters / other setters so
props.initialClientFilters is applied even when persistenceDisabled is true.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 6ed49f0b-b594-48bc-ad67-dee4aa7ea1c1
⛔ Files ignored due to path filters (1)
js/app/bun.lockis excluded by!**/*.lock,!**/bun.lock
📒 Files selected for processing (7)
js/app/package.jsonjs/app/packages/app/component/next-soup/soup-view/filters-bar/active-filter-chips.tsxjs/app/packages/app/component/next-soup/soup-view/filters-bar/mobile-filter-drawer.tsxjs/app/packages/app/component/next-soup/soup-view/filters-bar/soup-filters-bar.tsxjs/app/packages/app/component/next-soup/soup-view/soup-view-create-button.tsxjs/app/packages/app/component/next-soup/soup-view/soup-view-tabs.tsxjs/app/packages/app/component/next-soup/soup-view/soup-view.tsx
js/app/packages/app/component/next-soup/soup-view/filters-bar/mobile-filter-drawer.tsx
Outdated
Show resolved
Hide resolved
js/app/packages/app/component/next-soup/soup-view/filters-bar/mobile-filter-drawer.tsx
Outdated
Show resolved
Hide resolved
js/app/packages/app/component/next-soup/soup-view/soup-view.tsx
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
js/app/packages/app/component/next-soup/soup-view/filters-bar/unified-filter-dropdown.tsx (1)
505-510:⚠️ Potential issue | 🟠 MajorKeep all filter helper signatures typed to
FilterOption['id'], notstring.
FilterOption.idis strongly typed toFilterID, but multiple helpers widen it back tostring. This gives up the compiler protection. Note thatmobile-filter-drawer.tsxalready uses the correct signature fortoggleFilter, establishing the pattern.The issue exists in two files:
unified-filter-dropdown.tsx(lines 505, 509)use-filter-refinements.ts(lines 174, 178) — also has unnecessaryas FilterIDcasts (lines 179, 185–186) that can be removed once parameters are properly typed♻️ Proposed fixes
unified-filter-dropdown.tsx:
- const isOptionActive = (optionId: string) => { + const isOptionActive = (optionId: FilterOption['id']) => { return soup.filters.isActive(optionId); }; - const toggleFilter = (optionId: string) => { + const toggleFilter = (optionId: FilterOption['id']) => { soup.filters.toggle({ or: [optionId] }); };use-filter-refinements.ts:
- const isOptionActive = (optionId: string) => { + const isOptionActive = (optionId: FilterOption['id']) => { return soup.filters.isActive(optionId); }; - const removeFilter = (optionId: string) => { - soup.filters.toggle({ or: [optionId as FilterID] }); + const removeFilter = (optionId: FilterOption['id']) => { + soup.filters.toggle({ or: [optionId] }); }; const swapFilter = (oldOptionId: string, newOptionId: string) => {(Also remove
as FilterIDcasts on lines 185–186 when swapFilter parameters are updated similarly.)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@js/app/packages/app/component/next-soup/soup-view/filters-bar/unified-filter-dropdown.tsx` around lines 505 - 510, Update the helper function signatures to use FilterOption['id'] (the FilterID) instead of string: change isOptionActive(optionId: string) => isOptionActive(optionId: FilterOption['id']) and toggleFilter(optionId: string) => toggleFilter(optionId: FilterOption['id']) in unified-filter-dropdown.tsx, and similarly update swapFilter/toggle helpers in use-filter-refinements.ts to accept FilterOption['id']; after that remove the unnecessary `as FilterID` casts (lines noted) because the parameter types now match the expected FilterID. Ensure you update all related call sites to keep types consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@js/app/packages/app/component/next-soup/soup-view/filters-bar/mobile-filter-drawer.tsx`:
- Around line 181-189: The Accordion.Trigger elements remove the native focus
ring via the "outline-none" class, leaving keyboard focus invisible; update the
Accordion.Trigger (the element with class "w-full flex items-center ...
outline-none") to either remove "outline-none" or replace it with accessible
focus styles (e.g., add focus-visible:ring, focus-visible:ring-offset, and
focus-visible:ring-accent or a clear focus-visible:outline class) so the header
shows a visible focus indicator when tabbing; apply the same change to the other
Accordion.Trigger instance used in this file so both triggers regain an
accessible keyboard focus style.
- Around line 127-149: Drawer.Content is rendered without an accessible name
because the visible "Filters" header is commented out; add an accessible name by
giving Drawer.Content either an aria-label="Filters" or aria-labelledby that
references the header element (or restore the commented header and set
aria-labelledby to its id). Update the Drawer.Content props (the element named
Drawer.Content) to include the chosen attribute so screen readers announce the
drawer.
---
Outside diff comments:
In
`@js/app/packages/app/component/next-soup/soup-view/filters-bar/unified-filter-dropdown.tsx`:
- Around line 505-510: Update the helper function signatures to use
FilterOption['id'] (the FilterID) instead of string: change
isOptionActive(optionId: string) => isOptionActive(optionId: FilterOption['id'])
and toggleFilter(optionId: string) => toggleFilter(optionId: FilterOption['id'])
in unified-filter-dropdown.tsx, and similarly update swapFilter/toggle helpers
in use-filter-refinements.ts to accept FilterOption['id']; after that remove the
unnecessary `as FilterID` casts (lines noted) because the parameter types now
match the expected FilterID. Ensure you update all related call sites to keep
types consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: b55550a9-d8a7-4dd4-8664-1d15a2c639d2
📒 Files selected for processing (2)
js/app/packages/app/component/next-soup/soup-view/filters-bar/mobile-filter-drawer.tsxjs/app/packages/app/component/next-soup/soup-view/filters-bar/unified-filter-dropdown.tsx
js/app/packages/app/component/next-soup/soup-view/filters-bar/mobile-filter-drawer.tsx
Show resolved
Hide resolved
js/app/packages/app/component/next-soup/soup-view/filters-bar/mobile-filter-drawer.tsx
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@js/app/packages/app/component/next-soup/soup-view/filters-bar/mobile-filter-drawer.tsx`:
- Around line 227-229: The category option label span currently uses className
cn('flex-1 truncate') and lacks the active/inactive text color logic used for
assignees; update the span rendering {option.label} in the category options (the
span with class cn('flex-1 truncate')) to include the same conditional class
logic as the assignee option (apply 'text-ink' when option.active/selected and
'text-ink-muted' otherwise) by extending the cn call to include the conditional
text color so both category and assignee labels render consistently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: ace811b0-c055-45ba-b9c3-32c4df6023c9
⛔ Files ignored due to path filters (1)
js/app/bun.lockis excluded by!**/*.lock,!**/bun.lock
📒 Files selected for processing (2)
js/app/package.jsonjs/app/packages/app/component/next-soup/soup-view/filters-bar/mobile-filter-drawer.tsx
Comment on lines
+227
to
+229
| <span class={cn('flex-1 truncate')}> | ||
| {option.label} | ||
| </span> |
Contributor
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Minor styling inconsistency between category and assignee options.
Category filter option labels (line 227-229) don't apply conditional text color, while assignee option labels (lines 301-305) use text-ink when active and text-ink-muted when inactive. Consider aligning the styling for visual consistency:
- <span class={cn('flex-1 truncate')}>
+ <span class={cn('flex-1 truncate', active() ? 'text-ink' : 'text-ink-muted')}>
{option.label}
</span>Also applies to: 301-305
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@js/app/packages/app/component/next-soup/soup-view/filters-bar/mobile-filter-drawer.tsx`
around lines 227 - 229, The category option label span currently uses className
cn('flex-1 truncate') and lacks the active/inactive text color logic used for
assignees; update the span rendering {option.label} in the category options (the
span with class cn('flex-1 truncate')) to include the same conditional class
logic as the assignee option (apply 'text-ink' when option.active/selected and
'text-ink-muted' otherwise) by extending the cn call to include the conditional
text color so both category and assignee labels render consistently.
…mobile-new-soup-filter-bar
This was referenced Mar 30, 2026
This was referenced Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On mobile, instead of using the filter drop down, the filter button opens a drawer.