Skip to content

fix(search): local client side filter#2235

Merged
gbirman merged 1 commit intomainfrom
gab/fix/folder-search
Mar 27, 2026
Merged

fix(search): local client side filter#2235
gbirman merged 1 commit intomainfrom
gab/fix/folder-search

Conversation

@gbirman
Copy link
Copy Markdown
Contributor

@gbirman gbirman commented Mar 27, 2026

this client side filter will filter out local fuzzy matches for non-folder items, the backend response is fine though

@gbirman gbirman requested a review from a team as a code owner March 27, 2026 15:33
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: bce77fe1-850e-46e5-b66b-847de2fc6e54

📥 Commits

Reviewing files that changed from the base of the PR and between db8b469 and bbaa58d.

📒 Files selected for processing (1)
  • js/app/packages/app/component/app-sidebar/soup-filter-presets.ts

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved folder filtering consistency across the folders view tabs for more accurate folder display.

Walkthrough

The folders view tab presets in the soup filter configuration were modified to enable client-side folder filtering. The owned and all tabs now apply an explicit conjunction filter for folders instead of empty filter objects.

Changes

Cohort / File(s) Summary
Folder view tab presets
js/app/packages/app/component/app-sidebar/soup-filter-presets.ts
Updated clientFilters for the owned and all tabs from empty objects to { and: ['folders'] } to apply client-side folder filtering.
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title follows conventional commits format with 'fix:' prefix and is under 72 characters (37 chars), but is somewhat vague about the specific change being made.
Description check ✅ Passed The description directly addresses the PR's intent by explaining the client-side folder filtering behavior and its relationship to the backend response.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

@gbirman gbirman merged commit 9def0a0 into main Mar 27, 2026
23 checks passed
@gbirman gbirman deleted the gab/fix/folder-search branch March 27, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant