Skip to content

fix(soup): use sortTs for email thread ordering and display#2238

Merged
evanhutnik merged 1 commit intomainfrom
evan/fix-soup-ordering
Mar 27, 2026
Merged

fix(soup): use sortTs for email thread ordering and display#2238
evanhutnik merged 1 commit intomainfrom
evan/fix-soup-ordering

Conversation

@evanhutnik
Copy link
Copy Markdown
Contributor

Summary

Email threads in soup were displaying updatedAt as the timestamp and being client-side sorted by updatedAt/createdAt/viewedAt, which does not match the backend actual sort order (effective_ts / sortTs). This caused emails to appear in the wrong order and show incorrect timestamps.

  • Add sortTs to EntityBase and map it from the soup API response for email threads
  • Use sortTs as the preferred timestamp in EntityTimestamp and SoupViewList for emails
  • Update client-side sort comparators (sortByUpdatedAt, sortByCreatedAt, sortByViewedAt) to prefer sortTs when present
  • Non-email entities are unaffected — they do not have sortTs and retain existing behavior

@evanhutnik evanhutnik requested a review from a team as a code owner March 27, 2026 19:30
@github-actions
Copy link
Copy Markdown

@evanhutnik evanhutnik merged commit 0747e1c into main Mar 27, 2026
22 checks passed
@evanhutnik evanhutnik deleted the evan/fix-soup-ordering branch March 27, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant