Skip to content

fix(new-channels): static spacing#2249

Merged
synoet merged 1 commit intomainfrom
synoet/new-channels-typing-indicator-static-spacing
Mar 30, 2026
Merged

fix(new-channels): static spacing#2249
synoet merged 1 commit intomainfrom
synoet/new-channels-typing-indicator-static-spacing

Conversation

@synoet
Copy link
Copy Markdown
Contributor

@synoet synoet commented Mar 30, 2026

No description provided.

@synoet synoet requested a review from a team as a code owner March 30, 2026 14:22
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

📝 Walkthrough

Summary by CodeRabbit

  • Documentation
    • Added documentation clarifying how sticky scrolling behaves in channels, including scenarios when messages arrive, receive reactions, or when users initiate replies.

Walkthrough

This pull request refactors the ThreadTypingIndicator component to always render its wrapper <div> with conditional content rendering, and adds new documentation describing sticky scrolling behavior expectations in channels.

Changes

Cohort / File(s) Summary
Component Refactoring
js/app/packages/channel/Thread/ThreadTypingIndicator.tsx
Moved layout wrapper rendering from conditional to always-present, with ThreadTypingIndicatorContent now rendering as a fragment instead of wrapping its own div. Layout classes remain functionally equivalent.
Documentation
js/app/packages/channel/docs/sticky-scrolling.md
Added new documentation page defining sticky scrolling behavior expectations, covering three scenarios: new message arrival, reaction addition to latest message, and reply input visibility at channel bottom.
🚥 Pre-merge checks | ❌ 2

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title follows conventional commits format with 'fix:' prefix and is under 72 characters (33 chars), but is vague and does not clearly describe the actual changes made. Make the title more descriptive by explaining what is being fixed, e.g., 'fix(ThreadTypingIndicator): use static spacing for layout wrapper' or similar.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relatedness to the changeset. Add a pull request description explaining the motivation for the changes, the impact on the ThreadTypingIndicator component, and why static spacing is needed.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@js/app/packages/channel/docs/sticky-scrolling.md`:
- Around line 3-8: Clarify the “bottom threshold” by specifying a concrete
metric and a named constant to use in code and docs: define a pixel-based
constant (e.g., SCROLL_THRESHOLD_PX = 100) and optionally a viewport-fraction
constant (e.g., SCROLL_THRESHOLD_RATIO = 0.05), update the docs to state
“considered at bottom if scrollHeight - (scrollTop + clientHeight) <=
SCROLL_THRESHOLD_PX or <= SCROLL_THRESHOLD_RATIO * clientHeight,” and reference
the runtime check function (e.g., isAtBottom() or checkIsAtBottom()) to read
that constant so sticky-scrolling behavior is applied deterministically for new
messages and reactions.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4d37bc3f-b81f-4b17-908d-7a2cc225db37

📥 Commits

Reviewing files that changed from the base of the PR and between 3a39e3d and ddeecef.

📒 Files selected for processing (2)
  • js/app/packages/channel/Thread/ThreadTypingIndicator.tsx
  • js/app/packages/channel/docs/sticky-scrolling.md

@synoet synoet merged commit 28e7462 into main Mar 30, 2026
23 checks passed
@synoet synoet deleted the synoet/new-channels-typing-indicator-static-spacing branch March 30, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant