Skip to content

chore: fix biome lint command#2272

Merged
synoet merged 1 commit intomainfrom
synoet/fix-biome
Mar 30, 2026
Merged

chore: fix biome lint command#2272
synoet merged 1 commit intomainfrom
synoet/fix-biome

Conversation

@synoet
Copy link
Copy Markdown
Contributor

@synoet synoet commented Mar 30, 2026

No description provided.

@synoet synoet requested a review from a team as a code owner March 30, 2026 18:46
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: aefa3f6c-9442-48b4-91a2-1b09193135d3

📥 Commits

Reviewing files that changed from the base of the PR and between a76fe87 and e6267f5.

📒 Files selected for processing (1)
  • js/app/package.json

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated linting rule configuration for import cycle detection.

Walkthrough

Updated the lint script in js/app/package.json to modify Biome's import-cycle skip rule. Changed the skip rule from nursery/noImportCycles to suspicious/noImportCycles, shifting which Biome lint issue category is excluded during lint runs.

Changes

Cohort / File(s) Summary
Lint Configuration
js/app/package.json
Updated lint script to change Biome's import-cycle skip rule from nursery/noImportCycles to suspicious/noImportCycles.
🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess whether the description relates to the changeset. Add a description explaining why the Biome skip rule was changed from nursery/noImportCycles to suspicious/noImportCycles and the impact of this change.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title follows conventional commits format with 'chore:' prefix and is well under 72 characters, accurately describing the change to the Biome lint command.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

@synoet synoet merged commit a62a9f3 into main Mar 30, 2026
23 checks passed
@synoet synoet deleted the synoet/fix-biome branch March 30, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant