Skip to content

feat(search): filter out local search from inbox#2286

Merged
gbirman merged 2 commits intomainfrom
gab/feat/filter-out-local-search-from-inbox
Mar 30, 2026
Merged

feat(search): filter out local search from inbox#2286
gbirman merged 2 commits intomainfrom
gab/feat/filter-out-local-search-from-inbox

Conversation

@gbirman
Copy link
Copy Markdown
Contributor

@gbirman gbirman commented Mar 30, 2026

we don't have valid FE filtering for this, cleanest to do this

@gbirman gbirman requested a review from a team as a code owner March 30, 2026 22:31
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Summary by CodeRabbit

Release Notes

  • New Features
    • Added option to disable local search filtering in list views. Inbox now uses server-side search exclusively, improving performance for large datasets.

Walkthrough

A disableLocalSearch optional flag has been added and threaded through the soup-view component hierarchy: from the component registry's inbox route configuration, through the SoupView and SoupViewContextProvider components, to the createSearchState function. When enabled, the flag prevents local fuzzy search computation from executing.

Changes

Cohort / File(s) Summary
Soup view component hierarchy
js/app/packages/app/component/next-soup/soup-view/create-search-state.ts, soup-view-context.tsx, soup-view.tsx
Added optional disableLocalSearch?: boolean prop across component interfaces and contexts. Prop is propagated through the component tree and controls whether local fuzzy search computation executes in the search state initialization.
Route configuration
js/app/packages/app/component/split-layout/componentRegistry.tsx
Updated inbox route registration to pass disableLocalSearch prop to SoupView component, enabling selective search behavior for this specific route.
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title follows conventional commits format with 'feat:' prefix, is under 72 characters (48 chars), and accurately describes the main change of disabling local search in the inbox.
Description check ✅ Passed The description, while brief, is related to the changeset by acknowledging the lack of valid front-end filtering and justifying the approach taken.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

@gbirman gbirman merged commit a255892 into main Mar 30, 2026
22 of 23 checks passed
@gbirman gbirman deleted the gab/feat/filter-out-local-search-from-inbox branch March 30, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant