fix(channels): exclude attachments from deleted messages

[synoet]

No description provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4315b583-2433-4d3f-9b6a-b9b631fee494

📥 Commits

Reviewing files that changed from the base of the PR and between e041beb and 61923a4.

📒 Files selected for processing (1)

• rust/cloud-storage/channels/src/outbound/pg_channels_repo/tests.rs

---

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes
  • Attachments belonging to soft-deleted messages are no longer returned by the channel-level attachments endpoint. Messages that are soft-deleted but still have active thread replies remain visible in message listings; only their attachments are excluded from channel attachment results.

Walkthrough

Updated channel attachments endpoint to exclude attachments whose parent messages are soft-deleted. Adjusted SQL in get_channel_attachments, updated fixtures to add an attachment tied to a soft-deleted message, and added tests asserting those attachments are omitted from channel-level results.

Changes

Cohort / File(s)	Summary
Query & Fixture rust/cloud-storage/channels/src/outbound/pg_channels_repo.rs, rust/cloud-storage/channels/fixtures/channels_repo.sql	Added AND m.deleted_at IS NULL to the get_channel_attachments query to exclude attachments whose messages are soft-deleted; updated fixture to add an attachment row for the soft-deleted message (msg2) and document expected exclusion.
Tests rust/cloud-storage/channels/src/outbound/pg_channels_repo/tests.rs	Added DELETED_MSG_ATTACHMENT constant, updated expectations for MSG2 attachments, and added channel_attachments_exclude_deleted_messages test asserting deleted-message attachments are not returned by get_channel_attachments.

Possibly related PRs

• chg(channels): return sender with attachments, bump clamp on limit #2278: Modifies the same get_channel_attachments query (adds message.sender_id selection and adjusts pagination cursor), indicating a closely related change to the query's join and selected fields.

🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to evaluate relevance to the changeset.	Add a description explaining the purpose of this change, such as why attachments from deleted messages should be excluded and any related context.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	Title follows conventional commits format with 'fix:' prefix, is under 72 characters (56 chars), and clearly describes the main change: excluding attachments from deleted messages.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@rust/cloud-storage/channels/fixtures/channels_repo.sql`:
- Around line 89-93: The fixture added attaches attachment
'00000000-0000-0000-0000-00000000a004' to MSG2, which conflicts with the test
assertion map.get(&MSG2).is_none(); update the test in outbound/pg_channels_repo
tests to expect MSG2 to have that attachment (replace map.get(&MSG2).is_none()
with an assertion that the entry exists, e.g., map.get(&MSG2).is_some()) and
adjust the expected attachment list for MSG2 to include the new attachment id
'00000000-0000-0000-0000-00000000a004' so the test reflects the updated fixture.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3ba336da-7175-42b3-8112-2a3fcd4b0837

📥 Commits

Reviewing files that changed from the base of the PR and between 35ff875 and e041beb.

⛔ Files ignored due to path filters (1)

• rust/cloud-storage/channels/.sqlx/query-6958dcc3ad28334546d21a169c3724111cd93d5304bf2d9da4dac7a1cc5ad77d.json is excluded by !**/.sqlx/**

📒 Files selected for processing (3)

• rust/cloud-storage/channels/fixtures/channels_repo.sql
• rust/cloud-storage/channels/src/outbound/pg_channels_repo.rs
• rust/cloud-storage/channels/src/outbound/pg_channels_repo/tests.rs