fix(email): use soup mark-done for 'e' key instead of email archive#2334
Merged
evanhutnik merged 1 commit intomainfrom Apr 1, 2026
Merged
fix(email): use soup mark-done for 'e' key instead of email archive#2334evanhutnik merged 1 commit intomainfrom
evanhutnik merged 1 commit intomainfrom
Conversation
… key The email block registered 'e' for archive, which blocked the soup-level mark-done action from firing. Removed the email-specific 'e' hotkey so the soup mark-done action (which already archives emails) takes over. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughRemoves archive thread functionality from email hotkey handling by eliminating the threadData parameter from the hotkey registration function and removing the associated handler and hotkey binding. Changes
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ehotkey (archive thread) fromblock-emailso the soup-level "mark done" action handles it insteadarchiveEmail()for email entities, so archiving still happensebehave consistently across all block types: mark done + navigate to next itemChanges
block-email/util/emailHotkeys.ts: Removede→ archive hotkey registration, removed unusedarchiveThreadfrom handler interface, removed unusedthreadDataparam and related importsblock-email/component/Email.tsx: UpdatedregisterEmailHotkeyscall to match new signature