Skip to content

fix(email): use soup mark-done for 'e' key instead of email archive#2334

Merged
evanhutnik merged 1 commit intomainfrom
evan/email-done-e
Apr 1, 2026
Merged

fix(email): use soup mark-done for 'e' key instead of email archive#2334
evanhutnik merged 1 commit intomainfrom
evan/email-done-e

Conversation

@evanhutnik
Copy link
Copy Markdown
Contributor

Summary

  • Removed the email-specific e hotkey (archive thread) from block-email so the soup-level "mark done" action handles it instead
  • The soup mark-done action already calls archiveEmail() for email entities, so archiving still happens
  • This makes e behave consistently across all block types: mark done + navigate to next item

Changes

  • block-email/util/emailHotkeys.ts: Removed e → archive hotkey registration, removed unused archiveThread from handler interface, removed unused threadData param and related imports
  • block-email/component/Email.tsx: Updated registerEmailHotkeys call to match new signature

… key

The email block registered 'e' for archive, which blocked the soup-level
mark-done action from firing. Removed the email-specific 'e' hotkey so
the soup mark-done action (which already archives emails) takes over.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@evanhutnik evanhutnik requested a review from a team as a code owner April 1, 2026 17:14
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: becec4c4-450b-47e6-b628-f7f3c75e8db2

📥 Commits

Reviewing files that changed from the base of the PR and between 62fce46 and edf060e.

📒 Files selected for processing (2)
  • js/app/packages/block-email/component/Email.tsx
  • js/app/packages/block-email/util/emailHotkeys.ts
💤 Files with no reviewable changes (1)
  • js/app/packages/block-email/util/emailHotkeys.ts

📝 Walkthrough

Summary by CodeRabbit

  • Refactor
    • Removed the email thread archive/unarchive hotkey (previously bound to the 'e' key). All other email navigation and sender management hotkeys remain functional and unchanged.

Walkthrough

Removes archive thread functionality from email hotkey handling by eliminating the threadData parameter from the hotkey registration function and removing the associated handler and hotkey binding.

Changes

Cohort / File(s) Summary
Archive Thread Functionality Removal
js/app/packages/block-email/component/Email.tsx, js/app/packages/block-email/util/emailHotkeys.ts
Removed archive thread capability by eliminating the threadData parameter from registerEmailHotkeys(), removing the archiveThread handler from EmailHotkeyHandlers, and deleting the 'e' hotkey registration that toggled archive/unarchive state.
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the conventional commits format (fix:) and is under 72 characters (67 chars), clearly summarizing the main change of removing email-specific archive hotkey.
Description check ✅ Passed The description is well-related to the changeset, clearly explaining why the email archive hotkey was removed and how the soup mark-done action replaces it.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

@evanhutnik evanhutnik merged commit 66a44a5 into main Apr 1, 2026
23 checks passed
@evanhutnik evanhutnik deleted the evan/email-done-e branch April 1, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant