Skip to content

fix(email): show full sender name when it starts with "The"#2413

Merged
evanhutnik merged 1 commit intomainfrom
evan/fix-the-sender-name
Apr 7, 2026
Merged

fix(email): show full sender name when it starts with "The"#2413
evanhutnik merged 1 commit intomainfrom
evan/fix-the-sender-name

Conversation

@evanhutnik
Copy link
Copy Markdown
Contributor

Summary

  • Fixes getFirstName in block-email/util/name.ts to return the full sender name when it starts with "The " (e.g. "The Vanta Team") instead of truncating to just "The"
  • Other sender names continue to show first name only as before

Previously getFirstName would truncate "The Vanta Team" to just "The".
Now returns the full name for senders starting with "The ".

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@evanhutnik evanhutnik requested a review from a team as a code owner April 7, 2026 18:04
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2dab6c4b-5000-4b7d-9ce8-3bd8261825b7

📥 Commits

Reviewing files that changed from the base of the PR and between 3a50f88 and 640aafa.

📒 Files selected for processing (1)
  • js/app/packages/block-email/util/name.ts

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Fixed incorrect name handling for names beginning with "the". These names now display in full with trailing punctuation removed, rather than being truncated to the first word.

Walkthrough

The getFirstName() function has been modified to special-case names starting with "the " (case-insensitive) by returning the full name with trailing commas removed instead of extracting the first space-delimited token. Other behavior remains unchanged.

Changes

Cohort / File(s) Summary
Name Utility Update
js/app/packages/block-email/util/name.ts
Modified getFirstName() to handle names beginning with "the " by preserving the entire name (with trailing commas removed) rather than splitting and returning the first token. Falsy input handling and general name processing unchanged.
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title follows conventional commits format (fix:) and is under 72 characters (59 chars), clearly describing the main change: fixing the getFirstName function to handle sender names starting with 'The'.
Description check ✅ Passed The description is directly related to the changeset, explaining the specific bug fix in getFirstName and how sender names starting with 'The' will now be handled differently.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@evanhutnik evanhutnik merged commit 428b0e1 into main Apr 7, 2026
23 checks passed
@evanhutnik evanhutnik deleted the evan/fix-the-sender-name branch April 7, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant