Skip to content

fix[mobile soup]: missing sender names#2448

Merged
peterchinman merged 1 commit intomainfrom
peter/missing-sender-name
Apr 8, 2026
Merged

fix[mobile soup]: missing sender names#2448
peterchinman merged 1 commit intomainfrom
peter/missing-sender-name

Conversation

@peterchinman
Copy link
Copy Markdown
Contributor

No description provided.

@peterchinman peterchinman requested a review from a team as a code owner April 8, 2026 19:50
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: c7879514-dbcd-43f9-881a-21e1c7102eac

📥 Commits

Reviewing files that changed from the base of the PR and between 16b4afd and 0008ae4.

📒 Files selected for processing (1)
  • js/app/packages/entity/src/composed/ListEntity.tsx

📝 Walkthrough

Summary by CodeRabbit

  • Refactor
    • Improved message display handling for channel entities to safely process sender information with more robust null/undefined checks.

Walkthrough

The ListEntity.tsx file was modified to refactor how the sender's first name is prefixed to channel message content. The change introduces an IIFE to safely extract the sender's name into a local variable before conditionally prefixing the message, replacing direct inline conditional string construction.

Changes

Cohort / File(s) Summary
Message sender prefix refactoring
js/app/packages/entity/src/composed/ListEntity.tsx
Refactored the StaticMarkdown markdown prop construction for channel entities' latestMessage to use an IIFE for safer sender name extraction and conditional prefix logic instead of inline conditional string building.

Possibly related PRs

  • macro-inc/macro PR 2080: Modifies the same ListEntity.tsx file with related changes to how channel latestMessage strings are constructed and prefixed with sender information.
🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relevance to the changeset. Add a pull request description explaining the fix, including what the issue was and how the changes resolve it.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title follows conventional commits format with 'fix' prefix and is under 72 characters, accurately summarizing the change to missing sender names.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

@peterchinman peterchinman merged commit bec6d81 into main Apr 8, 2026
23 checks passed
@peterchinman peterchinman deleted the peter/missing-sender-name branch April 8, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant