Skip to content

fix: radio button single select should no-op on reclick#2457

Merged
gbirman merged 1 commit intomainfrom
gab/fix/search-index-radio
Apr 8, 2026
Merged

fix: radio button single select should no-op on reclick#2457
gbirman merged 1 commit intomainfrom
gab/fix/search-index-radio

Conversation

@gbirman
Copy link
Copy Markdown
Contributor

@gbirman gbirman commented Apr 8, 2026

No description provided.

@gbirman gbirman requested a review from a team as a code owner April 8, 2026 22:58
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9c761a75-1e38-4797-9667-b5d2acf59a47

📥 Commits

Reviewing files that changed from the base of the PR and between f57fb61 and abe4279.

📒 Files selected for processing (1)
  • js/app/packages/app/component/next-soup/soup-view/filters-bar/filter-primitives.tsx

📝 Walkthrough

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Fixed single-select filter behavior to prevent unnecessary change events when no option is selected.

Walkthrough

Modified the FilterSelect component's handleChange function in single-select mode to return early when no selection is made, rather than invoking the callback with an empty array.

Changes

Cohort / File(s) Summary
Single-select filter behavior
js/app/packages/app/component/next-soup/soup-view/filters-bar/filter-primitives.tsx
Adjusted handleChange for single-select mode: returns early without invoking props.onChange when selected is falsy, and invokes it with a single-element array when selected is truthy. Multi-select behavior unchanged.
🚥 Pre-merge checks | ✅ 1 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to evaluate whether it relates to the changeset. Add a pull request description explaining the intent behind the change, such as the bug being fixed or the motivation for the behavior modification.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title follows conventional commits format with 'fix:' prefix and is under 72 characters (55 chars), clearly describing the behavior change for radio button single select.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

@gbirman gbirman merged commit 2e13867 into main Apr 8, 2026
23 checks passed
@gbirman gbirman deleted the gab/fix/search-index-radio branch April 8, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant