Skip to content

fix(notif): conn gateway timestamps#2467

Merged
seanaye merged 1 commit intomainfrom
seanaye/fix/conn-gateway-timestamps
Apr 9, 2026
Merged

fix(notif): conn gateway timestamps#2467
seanaye merged 1 commit intomainfrom
seanaye/fix/conn-gateway-timestamps

Conversation

@seanaye
Copy link
Copy Markdown
Contributor

@seanaye seanaye commented Apr 9, 2026

This pr updates the output to the queue such that the conn gateway message contain the timestamps as created from the db

@seanaye seanaye requested a review from a team as a code owner April 9, 2026 17:54
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1fd7be6d-c69c-47b5-a33a-939ebf4e9a40

📥 Commits

Reviewing files that changed from the base of the PR and between a5f4b4c and 8c6422f.

📒 Files selected for processing (2)
  • rust/cloud-storage/notification/src/domain/models/queue_message.rs
  • rust/cloud-storage/notification/src/domain/service/ingress.rs

📝 Walkthrough

Summary by CodeRabbit

  • Refactor
    • Enhanced internal notification timestamp handling to improve data consistency during message processing.

Walkthrough

Added timestamp-mutation methods (with_timestamps()) to NotificationChannel and QueueMessage types. Modified the ingress service to extract timestamps from database-created notification rows and thread them into each queue message before publishing.

Changes

Cohort / File(s) Summary
Timestamp Mutation Methods
rust/cloud-storage/notification/src/domain/models/queue_message.rs
Added NotificationChannel::with_timestamps() (private) and QueueMessage::with_timestamps() (pub(crate)) methods to support internal timestamp replacement for ConnGatewayInnerNotif variants while passing through other variants unchanged.
Ingress Service Integration
rust/cloud-storage/notification/src/domain/service/ingress.rs
Updated NotificationIngressService::send_notification_impl to extract created_at and updated_at timestamps from database rows and apply them to queue messages via the new with_timestamps() method during message publication.
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed Title follows conventional commits format with 'fix:' prefix and is well under 72 characters, clearly describing the change to connection gateway timestamps.
Description check ✅ Passed Description is directly related to the changeset, explaining that the PR updates queue output so connection gateway messages contain database-created timestamps.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gbirman
Copy link
Copy Markdown
Contributor

gbirman commented Apr 9, 2026

can we update the schema response timestamp type to not be optional?

@seanaye
Copy link
Copy Markdown
Contributor Author

seanaye commented Apr 9, 2026

can we update the schema response timestamp type to not be optional?

can we update the schema response timestamp type to not be optional?

ill do in a follow up

@seanaye seanaye merged commit c6b0b34 into main Apr 9, 2026
38 of 39 checks passed
@seanaye seanaye deleted the seanaye/fix/conn-gateway-timestamps branch April 9, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants