Skip to content

add logging#2483

Merged
seanaye merged 1 commit intomainfrom
seanaye/chore/logging
Apr 9, 2026
Merged

add logging#2483
seanaye merged 1 commit intomainfrom
seanaye/chore/logging

Conversation

@seanaye
Copy link
Copy Markdown
Contributor

@seanaye seanaye commented Apr 9, 2026

No description provided.

@seanaye seanaye requested a review from a team as a code owner April 9, 2026 21:40
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1fdc68af-2c69-41e5-96de-1a131912e9c0

📥 Commits

Reviewing files that changed from the base of the PR and between 5de8f3f and 616e3ec.

📒 Files selected for processing (2)
  • rust/cloud-storage/invite_email/src/lib.rs
  • rust/cloud-storage/notification/src/outbound/repository.rs

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Improved email rate-limiting granularity for channel invitations.
    • Enhanced notification data retrieval for more accurate event tracking.

Walkthrough

Modified rate-limiting key for channel invite emails to include channel name, and updated user notification mapping to attach the original event item type to EntityType construction in the repository layer.

Changes

Cohort / File(s) Summary
Email rate limiting
rust/cloud-storage/invite_email/src/lib.rs
Added channel_name to the rate-limiting key for ChannelInviteMetadata in NotificationExtEmail, refining the granularity of rate limiting for channel invitation emails.
Notification repository
rust/cloud-storage/notification/src/outbound/repository.rs
Enhanced EntityType construction in get_user_notifications to call .attach(row.event_item_type), supplementing the parsed entity type with the original event item type from the database row.

Possibly related PRs

🚥 Pre-merge checks | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'add logging' does not follow conventional commits format (missing prefix like feat:, fix:, chore:) and is vague about actual changes. Update title to follow conventional commits format (e.g., 'chore: update rate limiting key and entity type' or similar) and be more specific about the actual changes made.
Description check ⚠️ Warning No pull request description was provided by the author. Add a description explaining the purpose and rationale for the rate limiting key change and entity type attachment modification.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@seanaye seanaye merged commit 843c763 into main Apr 9, 2026
38 checks passed
@seanaye seanaye deleted the seanaye/chore/logging branch April 9, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant