fix(search): not all documents showing for search soup index

[gbirman]

changing to document-or-file to handle file search, also bumping version so people get updates

[coderabbitai]

Warning

Rate limit exceeded

@gbirman has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 6 minutes and 50 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 6 minutes and 50 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 51aea90b-228d-4aec-8c97-00bc39aa42cd

📥 Commits

Reviewing files that changed from the base of the PR and between 06de5d5 and 5b66ddd.

📒 Files selected for processing (2)

• js/app/packages/app/component/next-soup/soup-view/soup-view.tsx
• js/app/packages/core/util/dateSearch/useDateSearch.test.ts

📝 Walkthrough

Walkthrough

Updated the Documents filter backing value from document to document-or-file in search-filter-controls.tsx, and incremented SoupView persisted state version from 1 to 2 in soup-view.tsx so persisted queryFilters are treated as stale and not reapplied on mount.

Changes

Cohort / File(s)	Summary
Search filter control js/app/packages/app/component/next-soup/soup-view/filters-bar/search-filter-controls.tsx	Changed the Documents index option backing value from 'document' → 'document-or-file'; displayed label/icon and QUERY_FILTERS.documentAndFile remain unchanged.
Soup view persisted state js/app/packages/app/component/next-soup/soup-view/soup-view.tsx	Bumped PERSISTED_STATE_VERSION 1 → 2 and changed mount logic to treat persisted queryFilters as stale (initial mount sets query filters to {} when stale).

Possibly related PRs

• fix(search): local fuzzy document search returns non-document results #2242: Same changes to Documents index backing value and SoupView persisted-state handling.
• feat: search tab filter selection #2453: Touches INDEX_OPTIONS/search index controls and the Documents index option logic referenced here.
• feat[soup]: persist state per tab #2218: Related modifications to PERSISTED_STATE_VERSION and persisted-state restoration in soup-view.tsx.

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title follows conventional commits format with 'fix:' prefix and is 60 characters, within the 72-character limit. It clearly summarizes the main change addressing the search soup index issue.
Description check	✅ Passed	The description is related to the changeset, explaining the switch to document-or-file filter for file search and the version bump mentioned in the file changes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Preview: https://gab-fix-search-soup-index-r64mob.preview.macro.com/app (9e269f6)

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@js/app/packages/app/component/next-soup/soup-view/soup-view.tsx`:
- Line 171: The persisted state version bump (PERSISTED_STATE_VERSION) isn't
enough because when isStale is true the code still assigns
initialPersistedState.queryFilters (see usage around
initialPersistedState/queryFilters and isStale); change the initialization logic
that applies initialPersistedState (the block referencing
initialPersistedState.queryFilters) so that if isStale is true you do not
restore queryFilters (reset them to the default empty/undefined value instead),
i.e., skip or overwrite initialPersistedState.queryFilters when isStale is true
to prevent carrying forward stale filter semantics.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: e4d96aa5-aa4e-4684-ad3c-cbe80d9a410c

📥 Commits

Reviewing files that changed from the base of the PR and between 2aa269d and f033c27.

📒 Files selected for processing (2)

• js/app/packages/app/component/next-soup/soup-view/filters-bar/search-filter-controls.tsx
• js/app/packages/app/component/next-soup/soup-view/soup-view.tsx

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@js/app/packages/app/component/next-soup/soup-view/soup-view.tsx`:
- Around line 678-680: The current stale-state restore unconditionally clears
query filters by calling setQueryFilters(isStale ? {} :
(initialPersistedState.queryFilters ?? {})), which wipes default filter presets;
change the logic in the component so that when isStale is true you do not
override defaults—only apply persisted filters when
initialPersistedState.queryFilters is present, otherwise keep existing defaults
(e.g., leave query filters untouched or initialize from
soup.filters/defaultQueryFilters). Update the branch around setQueryFilters to
use initialPersistedState.queryFilters when defined, otherwise skip calling
setQueryFilters or use soup.filters as the fallback, keeping references to
setQueryFilters, initialPersistedState.queryFilters, isStale, and soup.filters
to locate the code.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: bdfce4d1-8b53-4325-b4ec-a77fc42c50cc

📥 Commits

Reviewing files that changed from the base of the PR and between f033c27 and 06de5d5.

📒 Files selected for processing (1)

• js/app/packages/app/component/next-soup/soup-view/soup-view.tsx