Skip to content

fix(search): keep In/From chip popup open on multi-select#2637

Merged
gbirman merged 2 commits into
mainfrom
fix-search-email-filter-multiselect
Apr 16, 2026
Merged

fix(search): keep In/From chip popup open on multi-select#2637
gbirman merged 2 commits into
mainfrom
fix-search-email-filter-multiselect

Conversation

@gbirman
Copy link
Copy Markdown
Contributor

@gbirman gbirman commented Apr 16, 2026

channel search in/from filters multi-select stays open. also prevents hover/click state on the user icon in the in filter. also i disable click/hover state on the channel entity icon in the in: filter so you don't accidentally click the channel when you don't want to

The active-filters list rebuilds filter objects on every selection, so
<For> destroys and re-mounts the chip, losing its open state. Hoist the
chip's open/search signals into a module-level map keyed by category
label so they survive remounts, and set closeOnSelection={false} +
selectionBehavior="toggle" on the multi-select combobox.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 16, 2026

Warning

Rate limit exceeded

@gbirman has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 25 minutes and 47 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 25 minutes and 47 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0dc9e742-fd73-44b7-bbf9-f57c6a67fc73

📥 Commits

Reviewing files that changed from the base of the PR and between eb8658b and da5a22c.

📒 Files selected for processing (3)
  • js/app/packages/app/component/next-soup/soup-view/filters-bar/active-filter-chips.tsx
  • js/app/packages/app/component/next-soup/soup-view/filters-bar/search-filter-controls.tsx
  • js/app/packages/entity/src/extractors/entity-icon.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2026

DM channel avatars in the In filter had a clickable UserIcon that
navigated away on click and showed a tooltip. Plumb suppressClick and
showTooltip={false} through EntityIcon → DirectMessageIcon → UserIcon so
the In filter icons stay static like the From filter.
@gbirman gbirman merged commit 13ff058 into main Apr 16, 2026
23 checks passed
@gbirman gbirman deleted the fix-search-email-filter-multiselect branch April 16, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant