fix(favicon): make favicon badge a0 instead of a1

[aidanhb]

No description provided.

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes
  • Updated favicon badge color to align with the app's accent color for improved visual consistency.

Walkthrough

Updated ReactiveFavicon's badgeColor to use the same theme color key ('a0') as accentColor, replacing the previous distinct key ('a1'). All other component functionality remains unchanged.

Changes

Cohort / File(s)	Summary
Theme Color Synchronization js/app/packages/app/component/ReactiveFavicon.tsx	Changed badgeColor reactive value to use theme color key 'a0' (matching accentColor) instead of 'a1', aligning badge coloring with the accent color source.

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to assess relevance to the changeset.	Add a pull request description explaining the rationale for changing the favicon badge color from 'a1' to 'a0' and any related context.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title follows conventional commits format with 'fix:' prefix, is under 72 characters, and accurately describes the main change: updating the favicon badge color from 'a1' to 'a0'.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Preview: https://aidan-favicon-badge-gigcor.preview.macro.com/app (c58b3cd)

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@js/app/packages/app/component/ReactiveFavicon.tsx`:
- Around line 15-16: badgeColor is a redundant reactive binding mirroring
accentColor; remove the duplicate useReactiveColorString('a0') assignment (the
badgeColor declaration) and change the call site in updateFavicon to pass
accentColor() for the badge color argument (and replace any other uses of
badgeColor with accentColor or accentColor()); ensure you remove the extra
signal subscription and any unused import/variable for badgeColor.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: ce1d6cbc-c0bf-4d4c-abc7-66f0305163f7

📥 Commits

Reviewing files that changed from the base of the PR and between 3dc2dda and 2376970.

📒 Files selected for processing (1)

• js/app/packages/app/component/ReactiveFavicon.tsx

[coderabbitai]

🧹 Nitpick | 🔵 Trivial

Redundant duplicate reactive color binding.

badgeColor now resolves to exactly the same reactive string as accentColor. Consider dropping the second binding and passing accentColor() for both arguments in updateFavicon (line 61) to avoid the extra signal subscriptions and the misleading impression that the two colors can diverge.

♻️ Proposed simplification

-  const accentColor = useReactiveColorString('a0');
-  const badgeColor = useReactiveColorString('a0');
+  const accentColor = useReactiveColorString('a0');
@@
-    updateFavicon(accentColor(), badgeColor(), showNotificationBadge());
+    updateFavicon(accentColor(), accentColor(), showNotificationBadge());

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@js/app/packages/app/component/ReactiveFavicon.tsx` around lines 15 - 16,
badgeColor is a redundant reactive binding mirroring accentColor; remove the
duplicate useReactiveColorString('a0') assignment (the badgeColor declaration)
and change the call site in updateFavicon to pass accentColor() for the badge
color argument (and replace any other uses of badgeColor with accentColor or
accentColor()); ensure you remove the extra signal subscription and any unused
import/variable for badgeColor.