Skip to content

feat(onboarding): refine sidebar glow, lesson flow, and editor interactions#2725

Merged
evanhutnik merged 2 commits into
mainfrom
evan/onboarding-v3
Apr 21, 2026
Merged

feat(onboarding): refine sidebar glow, lesson flow, and editor interactions#2725
evanhutnik merged 2 commits into
mainfrom
evan/onboarding-v3

Conversation

@evanhutnik
Copy link
Copy Markdown
Contributor

Summary

Polish pass on the interactive onboarding flow.

Glow

  • Tightened the sidebar highlight pulse: brighter alpha, smaller blur radius. Keeps the icon halo noticeable without blooming across the sidebar.

Lesson flow

  • Swapped the order so Create comes before Command Menu.
  • Create now completes as soon as the launcher opens (hotkey C or the + button) — no longer requires picking a block type. Refactored the completion trigger from a createEffect to a wrapped setter per AGENTS.md.
  • Fixed a focus bug on the Create step: when the user picked a block, the Dialog's close-auto-focus stole focus back to whatever opened it, so Enter couldn't advance the lesson. Now Dialog.Content preventDefaults close-auto-focus once the lesson is complete and re-triggers onComplete so the parent refocuses the Continue button.

Editor step

  • Made the whole "Daily Note" pane a clickable text-input target (full-height wrapper + flex-1 min-h-0 cursor-text on the MarkdownShell). Click anywhere below the title to focus the editor.
  • Added a mention hotkey callout.

Copy

  • "Pick the plan that works best for your team." → "Pick the plan that matches how you want to use Macro."
  • About-us: "170k users" → "200k users".

…ctions

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 21, 2026

Warning

Rate limit exceeded

@evanhutnik has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 52 minutes and 24 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 52 minutes and 24 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4680d272-fb7d-486c-94ba-5b6f5a9baaa7

📥 Commits

Reviewing files that changed from the base of the PR and between 3b632a2 and 031e4e5.

📒 Files selected for processing (1)
  • js/app/packages/app/component/interactive-onboarding/lessons/markdown-mentions.tsx
📝 Walkthrough

Walkthrough

Updates to the interactive-onboarding component encompassing animation refinements, lesson content text changes, and lesson ordering/behavior adjustments across multiple lesson definitions.

Changes

Cohort / File(s) Summary
Animation Updates
js/app/packages/app/component/interactive-onboarding/components/MockAppChrome.tsx
Modified the sidebar-glow-pulse keyframes animation to use a multi-layer glow pattern with adjusted shadow spread, blur, and opacity levels.
Lesson Content Updates
js/app/packages/app/component/interactive-onboarding/lessons/about-us.tsx, choose-plan.tsx, markdown-mentions.tsx
Updated instructional text and copy: user count from 170k to 200k, plan selection guidance, mention example; removed subtitle field from markdown-mentions lesson definition.
Lesson Metadata & Behavior
js/app/packages/app/component/interactive-onboarding/lessons/command-k.tsx, create-entity.tsx
Adjusted lesson ordering (command-k: 40→45, create-entity: 45→40); refactored launcher state management in create-entity with callback registration and focus-management improvements; updated sidebar navigation label in command-k.

Possibly related PRs

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning Title exceeds 72-character limit at 75 characters but follows conventional commits format (feat:) and accurately describes the main changes. Shorten title to 72 characters or less, e.g., 'feat(onboarding): refine sidebar glow and lesson flow' (52 chars).
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed Description is comprehensive and directly related to all file changes including sidebar glow, lesson reordering, focus management, editor interactions, and copy updates.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
js/app/packages/app/component/interactive-onboarding/lessons/markdown-mentions.tsx (1)

16-24: ⚠️ Potential issue | 🟡 Minor

Keep the mention copy consistent.

The callout says @ is “to mention someone”, but the new instruction asks users to mention “something”, and the config includes both entities and users. Align the wording so users know documents/tasks/etc. are valid targets too.

Suggested copy alignment
       <HotkeyCallout
         keys={['@']}
-        label="to mention someone"
+        label="to mention people or items"
         completed={completed()}
       />
       <p>
         Macro's editor supports rich markdown, mentions, and emoji. Try
-        mentioning something by typing <strong>@</strong> in the editor.
+        mentioning people or items by typing <strong>@</strong> in the editor.
       </p>
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@js/app/packages/app/component/interactive-onboarding/lessons/markdown-mentions.tsx`
around lines 16 - 24, Update the mention wording to be consistent and inclusive
of users and non-user entities: change the HotkeyCallout label (HotkeyCallout
props) from "to mention someone" to a neutral phrase like "to mention someone or
something" (or "to mention a person or item"), and update the paragraph copy
that currently says "mentioning something" to match that same phrasing so both
the HotkeyCallout label and the descriptive text refer to users and other
targets (documents/tasks/etc.) consistently; modify the label prop and the
paragraph text in markdown-mentions.tsx and keep completed() usage unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In
`@js/app/packages/app/component/interactive-onboarding/lessons/markdown-mentions.tsx`:
- Around line 16-24: Update the mention wording to be consistent and inclusive
of users and non-user entities: change the HotkeyCallout label (HotkeyCallout
props) from "to mention someone" to a neutral phrase like "to mention someone or
something" (or "to mention a person or item"), and update the paragraph copy
that currently says "mentioning something" to match that same phrasing so both
the HotkeyCallout label and the descriptive text refer to users and other
targets (documents/tasks/etc.) consistently; modify the label prop and the
paragraph text in markdown-mentions.tsx and keep completed() usage unchanged.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: db0b1569-b60e-4079-993b-32f6c311a7aa

📥 Commits

Reviewing files that changed from the base of the PR and between 78c906c and 3b632a2.

📒 Files selected for processing (6)
  • js/app/packages/app/component/interactive-onboarding/components/MockAppChrome.tsx
  • js/app/packages/app/component/interactive-onboarding/lessons/about-us.tsx
  • js/app/packages/app/component/interactive-onboarding/lessons/choose-plan.tsx
  • js/app/packages/app/component/interactive-onboarding/lessons/command-k.tsx
  • js/app/packages/app/component/interactive-onboarding/lessons/create-entity.tsx
  • js/app/packages/app/component/interactive-onboarding/lessons/markdown-mentions.tsx

Align mention-step copy so both the HotkeyCallout label and the
paragraph refer to "someone or something" — the mentions config
supports both users and entities.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@evanhutnik evanhutnik merged commit 9c7188e into main Apr 21, 2026
23 checks passed
@evanhutnik evanhutnik deleted the evan/onboarding-v3 branch April 21, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant