feat(onboarding): refine sidebar glow, lesson flow, and editor interactions#2725
Conversation
…ctions Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 52 minutes and 24 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdates to the interactive-onboarding component encompassing animation refinements, lesson content text changes, and lesson ordering/behavior adjustments across multiple lesson definitions. Changes
Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
js/app/packages/app/component/interactive-onboarding/lessons/markdown-mentions.tsx (1)
16-24:⚠️ Potential issue | 🟡 MinorKeep the mention copy consistent.
The callout says
@is “to mention someone”, but the new instruction asks users to mention “something”, and the config includes both entities and users. Align the wording so users know documents/tasks/etc. are valid targets too.Suggested copy alignment
<HotkeyCallout keys={['@']} - label="to mention someone" + label="to mention people or items" completed={completed()} /> <p> Macro's editor supports rich markdown, mentions, and emoji. Try - mentioning something by typing <strong>@</strong> in the editor. + mentioning people or items by typing <strong>@</strong> in the editor. </p>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@js/app/packages/app/component/interactive-onboarding/lessons/markdown-mentions.tsx` around lines 16 - 24, Update the mention wording to be consistent and inclusive of users and non-user entities: change the HotkeyCallout label (HotkeyCallout props) from "to mention someone" to a neutral phrase like "to mention someone or something" (or "to mention a person or item"), and update the paragraph copy that currently says "mentioning something" to match that same phrasing so both the HotkeyCallout label and the descriptive text refer to users and other targets (documents/tasks/etc.) consistently; modify the label prop and the paragraph text in markdown-mentions.tsx and keep completed() usage unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In
`@js/app/packages/app/component/interactive-onboarding/lessons/markdown-mentions.tsx`:
- Around line 16-24: Update the mention wording to be consistent and inclusive
of users and non-user entities: change the HotkeyCallout label (HotkeyCallout
props) from "to mention someone" to a neutral phrase like "to mention someone or
something" (or "to mention a person or item"), and update the paragraph copy
that currently says "mentioning something" to match that same phrasing so both
the HotkeyCallout label and the descriptive text refer to users and other
targets (documents/tasks/etc.) consistently; modify the label prop and the
paragraph text in markdown-mentions.tsx and keep completed() usage unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: db0b1569-b60e-4079-993b-32f6c311a7aa
📒 Files selected for processing (6)
js/app/packages/app/component/interactive-onboarding/components/MockAppChrome.tsxjs/app/packages/app/component/interactive-onboarding/lessons/about-us.tsxjs/app/packages/app/component/interactive-onboarding/lessons/choose-plan.tsxjs/app/packages/app/component/interactive-onboarding/lessons/command-k.tsxjs/app/packages/app/component/interactive-onboarding/lessons/create-entity.tsxjs/app/packages/app/component/interactive-onboarding/lessons/markdown-mentions.tsx
Align mention-step copy so both the HotkeyCallout label and the paragraph refer to "someone or something" — the mentions config supports both users and entities. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
Polish pass on the interactive onboarding flow.
Glow
Lesson flow
Cor the+button) — no longer requires picking a block type. Refactored the completion trigger from acreateEffectto a wrapped setter perAGENTS.md.Dialog.ContentpreventDefaults close-auto-focus once the lesson is complete and re-triggersonCompleteso the parent refocuses the Continue button.Editor step
flex-1 min-h-0 cursor-texton theMarkdownShell). Click anywhere below the title to focus the editor.Copy